From: Avi Kivity <avi@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] KVM: VMX: Update necessary state when guest enters long mode
Date: Tue, 24 Feb 2009 12:26:32 +0200 [thread overview]
Message-ID: <49A3CB58.7060406@redhat.com> (raw)
In-Reply-To: <1235150617-15927-2-git-send-email-amit.shah@redhat.com>
Amit Shah wrote:
> setup_msrs() should be called when entering long mode to save the
> shadow state for the 64-bit guest state.
>
> Using vmx_set_efer() in enter_lmode() removes some duplicated code
> and also ensures we call setup_msrs(). We can safely pass the value
> of shadow_efer to vmx_set_efer() as no other bits in the efer change
> while enabling long mode (guest first sets EFER.LME, then sets CR0.PG
> which causes a vmexit where we activate long mode).
>
> With this fix, is_long_mode() can check for EFER.LMA set instead of
> EFER.LME and 5e23049e86dd298b72e206b420513dbc3a240cd9 can be reverted.
>
Applied, thanks. Good catch.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-02-24 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 17:23 VMX: Fix long mode activation Amit Shah
2009-02-20 17:23 ` [PATCH 1/1] KVM: VMX: Update necessary state when guest enters long mode Amit Shah
2009-02-24 10:26 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A3CB58.7060406@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.