From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Zeffertt Subject: [PATCH] [build system] make should fail if it cannot build hvmloader Date: Tue, 24 Feb 2009 12:13:01 +0000 Message-ID: <49A3E44D.6050508@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070504020600070009050606" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------070504020600070009050606 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit At the moment, if the tools required to build hvmloader are not present, make will continue building the rest of the system and not indicate that an error has occurred. This patch causes make to stop and print a message saying that some packages are missing on the build machine and need to be installed. Please consider applying the patch. Regards, Alex Zeffertt --------------070504020600070009050606 Content-Type: text/x-diff; name="tools-firmware-Makefile.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tools-firmware-Makefile.patch" # HG changeset patch # User Alex Zeffertt # Date 1235477069 0 # Node ID 72a8404eea4035d38129e2b2097fac5613f05f07 # Parent 32b15413749255e0cd518f25d9202759586dcb27 Make build fail if packages required to build hvmloader not present ... rather than just continuing as if nothing's gone wrong. Also, corrected the message generated by the makefile which says what packages are required. Signed-off-by: Alex Zeffertt diff -r 32b154137492 -r 72a8404eea40 tools/firmware/Makefile --- a/tools/firmware/Makefile Thu Feb 12 10:54:17 2009 +0000 +++ b/tools/firmware/Makefile Tue Feb 24 12:04:29 2009 +0000 @@ -15,13 +15,12 @@ .PHONY: all all: @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \ - echo "==========================================================="; \ - echo "Require dev86 package version >= 0.16.14 to build firmware!"; \ - echo "(visit http://www.cix.co.uk/~mayday for more information)"; \ - echo "==========================================================="; \ - else \ + echo "=================================================================="; \ + echo "Require bin86 & bcc packages version >= 0.16.14 to build firmware!"; \ + echo "=================================================================="; \ + false ; \ + fi $(MAKE) subdirs-$@; \ - fi .PHONY: install --------------070504020600070009050606 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------070504020600070009050606--