From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2/2 v5] New netfilter target to trigger LED devices Date: Tue, 24 Feb 2009 14:51:02 +0100 Message-ID: <49A3FB46.5060306@trash.net> References: <49934702.9060909@shikadi.net> <4993B34C.1020307@trash.net> <49940D58.3040404@shikadi.net> <49998E6C.2030504@trash.net> <1234878654.5312.34.camel@dax.rpnet.com> <499C17C2.9020502@trash.net> <499C899F.5010002@shikadi.net> <499E7E92.7030607@trash.net> <49A15E3C.3090809@shikadi.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Adam Nielsen Return-path: Received: from stinky.trash.net ([213.144.137.162]:65073 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754405AbZBXNvF (ORCPT ); Tue, 24 Feb 2009 08:51:05 -0500 In-Reply-To: <49A15E3C.3090809@shikadi.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Adam Nielsen wrote: >> Applied, thanks. I've made some minor cosmetic changes, like removal >> of /* noconst */ annotations and fixing indentation in one spot. >> >> You can look at the final commit at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git > > Thanks Patrick, looks fine. Did you fix the compile errors in your > other post, or do you still want me to look at them? It looks like it > was compiled with LED support disabled, which I thought the kernel > should take care of (not allowing the file to be compiled if LED support > was not present.) I did enable LED support to be able to select it. Might be a mistake when rebuilding on my side though, the latest patch compiles cleanly. > Did the other companion patch (1/2, the one to netfilter) also get > committed? Without that the new kernel module won't ever be used. That will get committed when the new -rc window starts so we don't include the userspace code in a release before the kernel part is released (and thus still can fix any mistakes that come up).