All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Johnson <lrj@acm.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Move test for unnecessary memmove to memmove_wd()
Date: Tue, 24 Feb 2009 16:36:26 -0500	[thread overview]
Message-ID: <49A4685A.10007@acm.org> (raw)
In-Reply-To: <20090222213445.C7816832E43F@gemini.denx.de>

Signed-off-by: Larry Johnson <lrj@acm.org>
---
 common/cmd_bootm.c |    7 ++-----
 common/image.c     |    3 +++
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 6fdeef4..bc38aaa 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -339,11 +339,8 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
 			printf ("   XIP %s ... ", type_name);
 		} else {
 			printf ("   Loading %s ... ", type_name);
-
-			if (load != image_start) {
-				memmove_wd ((void *)load,
-						(void *)image_start, image_len, CHUNKSZ);
-			}
+			memmove_wd ((void *)load, (void *)image_start,
+					image_len, CHUNKSZ);
 		}
 		*load_end = load + image_len;
 		puts("OK\n");
diff --git a/common/image.c b/common/image.c
index daa68bc..1dc9e4e 100644
--- a/common/image.c
+++ b/common/image.c
@@ -457,6 +457,9 @@ phys_size_t getenv_bootm_size(void)
 
 void memmove_wd (void *to, void *from, size_t len, ulong chunksz)
 {
+	if (to == from)
+		return;
+
 #if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
 	while (len > 0) {
 		size_t tail = (len > chunksz) ? chunksz : len;
-- 
1.5.4.3

  reply	other threads:[~2009-02-24 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18  0:05 [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove Minkyu Kang
2009-02-21 22:00 ` Wolfgang Denk
2009-02-22 16:05 ` Larry Johnson
2009-02-22 21:34   ` Wolfgang Denk
2009-02-24 21:36     ` Larry Johnson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-04-20 12:09 [U-Boot] [PATCH] Move test for unnecessary memmove to memmove_wd() Larry Johnson
2010-05-05 22:38 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A4685A.10007@acm.org \
    --to=lrj@acm.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.