From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Lennert Buytenhek <buytenh@marvell.com>,
Martin Michlmayr <tbm@cyrius.com>
Subject: Re: [PATCH] sata_mv: fix SoC interrupt breakage
Date: Wed, 25 Feb 2009 15:28:54 -0500 [thread overview]
Message-ID: <49A5AA06.7020201@pobox.com> (raw)
In-Reply-To: <499D7CDC.9000202@rtr.ca>
Mark Lord wrote:
> For some reason, sata_mv doesn't clear interrupt status during init
> when it's running on an SoC host adapter. If the bootloader has
> touched the SATA controller before starting Linux, Linux can end up
> enabling the SATA interrupt with events pending, which will cause the
> interrupt to be marked as spurious and then be disabled, which then
> breaks all further accesses to the controller.
>
> This patch makes the SoC path clear interrupt status on init like in
> the non-SoC case.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
>
> This is for 2.6.29 (upstream-fixes).
> Despite appearances, this patch simply removes a single unnecessary
> if-stmt from the code. It looks larger due to the resulting change
> in indentation level.
applied manually... not even patch(1) liked this one, and patch(1) is
far less strict than git-am patch import tool. Other peoples' patches
are processing just fine.
Jeff
prev parent reply other threads:[~2009-02-25 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 15:38 [PATCH] sata_mv: fix SoC interrupt breakage Mark Lord
2009-02-25 20:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A5AA06.7020201@pobox.com \
--to=jgarzik@pobox.com \
--cc=buytenh@marvell.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.