From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [patch 5/7] make netfilter use strict integer types Date: Wed, 25 Feb 2009 16:24:38 -0800 Message-ID: <49A5E146.4060208@zytor.com> References: <20090225235138.062045835@arndb.de> <20090225235515.682333715@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:36721 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978AbZBZAbj (ORCPT ); Wed, 25 Feb 2009 19:31:39 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jan Engelhardt Cc: arnd@arndb.de, Sam Ravnborg , Kyle McMartin , Ingo Molnar , Jaswinder Singh Rajput , mingo@redhat.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Jan Engelhardt wrote: > On Thursday 2009-02-26 00:51, arnd@arndb.de wrote: > >> Netfilter traditionally uses BSD integer types in its >> interface headers. This changes it to use the Linux >> strict integer types, like everyone else. > > I _strongly disagree_ with this move. Userspace also has the uintX > types via /, and now you are adding a dependency > on linux/types.h, not to mention that your step can lead to compile > time piling up. > > IMHO, __uXX should be replaced by uintX_t, but a move this great I > will leave to future generations because there is just too much > persisting opinions wrt. such proposal. As such I'd like to join > and persist on my position and that uintX that we have should be kept. > >> - u_int8_t flags; >> - u_int8_t mask; >> + __u8 flags; >> + __u8 mask; Not to mention the fact that the standard type is uint8_t, not u_int8_t as the file currently have, which makes it double broken. -hpa