All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] x86: signal: use 16 bytes boundary for rt_sigframe
Date: Fri, 27 Feb 2009 10:29:09 -0800	[thread overview]
Message-ID: <49A830F5.7090906@ct.jp.nec.com> (raw)
In-Reply-To: <49A83078.3020207@ct.jp.nec.com>

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Impact: cleanup

Supporting xsave/xrestore introduces 64 bytes boundary for save_i387_xstate().
16 bytes boundary is OK for rt_sigframe.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
 arch/x86/kernel/signal.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index 5ed4533..951aa60 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -409,15 +409,13 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t frame_size,
 	if (used_math()) {
 		sp -= sig_xstate_size;
 		*fpstate = (void __user *)round_down(sp, 64);
+
 		if (save_i387_xstate(*fpstate) < 0)
 			return (void __user *) -1L;
-
-		sp -= frame_size;
-		return (void __user *)round_down(sp, 16) - 8;
 	}
 
 	sp -= frame_size;
-	return (void __user *)round_down(sp, 64) - 8;
+	return (void __user *)round_down(sp, 16) - 8;
 }
 
 static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
-- 
1.6.1.2


  parent reply	other threads:[~2009-02-27 18:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-27 18:27 [PATCH 1/5] x86: signal: add __user annotation Hiroshi Shimamoto
2009-02-27 18:28 ` [PATCH 2/5] x86: signal: intrroduce get_sigframe() and replace get_sigstack() Hiroshi Shimamoto
2009-02-27 18:29 ` Hiroshi Shimamoto [this message]
2009-02-27 18:29 ` [PATCH 4/5] x86: signal: unify get_sigframe() Hiroshi Shimamoto
2009-02-27 18:30 ` [PATCH 5/5] x86: signal: introduce helper align_sigframe() Hiroshi Shimamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A830F5.7090906@ct.jp.nec.com \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.