From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LdN9M-0002Ia-AT for mharc-grub-devel@gnu.org; Sat, 28 Feb 2009 06:14:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LdN9K-0002IA-6B for grub-devel@gnu.org; Sat, 28 Feb 2009 06:14:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LdN9I-0002Hk-H2 for grub-devel@gnu.org; Sat, 28 Feb 2009 06:14:29 -0500 Received: from [199.232.76.173] (port=49056 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdN9I-0002Hg-AE for grub-devel@gnu.org; Sat, 28 Feb 2009 06:14:28 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:32384) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LdN9H-0004uW-SU for grub-devel@gnu.org; Sat, 28 Feb 2009 06:14:28 -0500 Received: by fg-out-1718.google.com with SMTP id l27so722804fgb.30 for ; Sat, 28 Feb 2009 03:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=ZaXV9M0A3Qg26V2JcmZEWc1kok4YHdNfJbulduTOCpc=; b=tv/fgXuIaPK98aTrLwfdRC/Lagwiml5PrVYWB78B2nsbW+Da8+HuUoanNXJ1E2l/1O y5ZW65xsTrnTbFyO0nOgg3zTRhnFJ2xbW4JSwtk53/PlXLB6ZLAOtUDfIekSnkqAemi0 BncpPvMxfMqDB8IdvjQ4+dNve6+fsF5aGvjfs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=b7WqzIpXHCkL7bIkTv+I/raTKx3DG2yGuH3fFHJINxNIXW3H4jGRnH//Quv7vHouZk /F6oYAcxEt4+oslxKrv7Z9yyV0YlzCqbPBo+T42eGXGHTsUOu9nQLtHEGCrOaUr+BvLi 3dDbyCfjssM2HS+vU83UR1yElHQcqoHNL9kQQ= Received: by 10.86.50.8 with SMTP id x8mr4912966fgx.14.1235819666810; Sat, 28 Feb 2009 03:14:26 -0800 (PST) Received: from ?192.168.1.25? (165-103.203-62.cust.bluewin.ch [62.203.103.165]) by mx.google.com with ESMTPS id 12sm9114814fgg.43.2009.02.28.03.14.26 (version=SSLv3 cipher=RC4-MD5); Sat, 28 Feb 2009 03:14:26 -0800 (PST) Message-ID: <49A91C92.2030708@gmail.com> Date: Sat, 28 Feb 2009 12:14:26 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Possible improvements to build system X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2009 11:14:30 -0000 Hello, I noticed that updating some pieces of code needs modification of nearly all *.rmk. IMO it's bad thing because e.g. it easily brings different architectures out of sync. My improvement propositions: 1. normal.mod There is one part which is CPU-dependent - setjmp.S. t's used only in static grub_err_t rescue_command (struct grub_arg_list *state __attribute__ ((unused)), int argc __attribute__ ((unused)), char **args __attribute__ ((unused))) { grub_longjmp (grub_exit_env, 0); /* Never reach here. */ return 0; } We could replace this longjmp by a call of grub_enter_rescue_mode and move the call to attempt_normal_mode to grub_main. Another possibility is to create a symlink normal/cpu during configure time and then during build time just use normal/cpu/setjmp.S 2. ata.mod, hdparm.mod, ata_pthru.mod, usbms.mod, ohci.mod, uhci.mod, usbtest.mod, usb.mod, memdisk.mod I don't see why these modules are in i386-pc.rmk and not in common.rmk 3. kernel.img, grub-setup These contain a number of files shared by all platforms. Like e.g. filesystems. I propose to create an additional file common-pre.rmk which could contain the variables like FS_files=... which platform-specific files can use later -- Regards Vladimir 'phcoder' Serbinenko