All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Daniel Mack <daniel@caiaq.de>
Cc: Pavel Machek <pavel@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: lis3's ACPI dependency
Date: Sun, 01 Mar 2009 19:28:01 +0100	[thread overview]
Message-ID: <49AAD3B1.4050501@tremplin-utc.net> (raw)
In-Reply-To: <20090301132953.GF20813@buzzloop.caiaq.de>

Daniel Mack schreef:
> Hi Pavel, Eric,
> 
> are there any plans to free the lis3 driver from its ACPI dependency?
> In fact, this device is I2C/SPI connected which the ACPI layer seems to
> hide from the driver, but to use it on embedded devices, the bus drivers
> must be used directly and the dependeny seems entirely unnecessary
> anyway.
> 
> Also I got the feeling that using a globally exported 'adev' symbol all
> over the different layers is not the best practice - I suspect all the
> occasions could be solved with private pointers and/or container_of().
> Isn't there any cleanup pending?
Hi Daniel,
Actually, the hp_accel.c file is dedicated to the acpi part. The
lis3lv02d.c file is supposed to be bus agnostic. In practice I agree
it's not completely true, but this is mainly because for now there is
only one bus supported (ACPI) and therefore the work for making it
completely bus-independent is not yet worthy. As soon as someone is
interested in writing a I²C/SPI interface it will become much more
apparent what has to be generalized.

Indeed, as you noticed, the main work left to do is to generalize
acpi_lis3lv02d (adev) to something ACPI independent. I'd say this could
be done simply by changing the signature of the four callback functions
and having device being just a void*.

If you are willing to write one of the I²C/SPI interfaces, I'll be happy
to support you.

See you,
Eric


  reply	other threads:[~2009-03-01 21:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-01 13:29 lis3's ACPI dependency Daniel Mack
2009-03-01 18:28 ` Éric Piel [this message]
2009-03-02  0:55   ` Daniel Mack
2009-03-02 10:17     ` Éric Piel
2009-03-02 14:31       ` Daniel Mack
2009-03-02 14:31         ` Daniel Mack
2009-03-02 14:31           ` [PATCH 3/5] lis3: reorder functions to make forward decl obsolete Daniel Mack
2009-03-02 14:31             ` [PATCH 4/5] lis3: solve dependency between core and ACPI Daniel Mack
2009-03-02 14:31               ` [PATCH 5/5] lis3: SPI transport layer Daniel Mack
2009-03-02 15:11                 ` Pavel Machek
2009-03-03 19:59                 ` Éric Piel
2009-03-02 15:10               ` [PATCH 4/5] lis3: solve dependency between core and ACPI Pavel Machek
2009-03-03 19:54               ` Éric Piel
2009-03-04  1:43                 ` Daniel Mack
2009-03-16 19:09                   ` Daniel Mack
2009-03-16 21:30                     ` Pavel Machek
2009-03-04  1:44                 ` [PATCH 3/5] lis3: reorder functions to make forward decl obsolete Daniel Mack
2009-03-04  1:44                   ` [PATCH 4/5] lis3: solve dependency between core and ACPI Daniel Mack
2009-03-04  1:44                     ` [PATCH 5/5] lis3: SPI transport layer Daniel Mack
2009-03-22 23:31                       ` Éric Piel
2009-03-23 15:41                         ` Daniel Mack
2009-03-22 23:25                     ` [PATCH 4/5] lis3: solve dependency between core and ACPI Éric Piel
2009-03-22 23:42                       ` Daniel Mack
2009-03-22 23:51                         ` [PATCH 1/3] lis3: reorder functions to make forward decl obsolete Daniel Mack
2009-03-22 23:51                           ` [PATCH 2/3] lis3: solve dependency between core and ACPI Daniel Mack
2009-03-22 23:51                             ` [PATCH 3/3] lis3: SPI transport layer Daniel Mack
2009-03-23 15:48                               ` Éric Piel
     [not found]                               ` <1237765887-32672-3-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2016-08-10 10:31                                 ` Geert Uytterhoeven
2016-08-10 10:31                                   ` Geert Uytterhoeven
2009-03-23 15:48                             ` [PATCH 2/3] lis3: solve dependency between core and ACPI Éric Piel
2009-03-23 15:48                           ` [PATCH 1/3] lis3: reorder functions to make forward decl obsolete Éric Piel
2009-03-02 14:57             ` [PATCH 3/5] " Pavel Machek
2009-03-02 14:36       ` lis3's ACPI dependency Daniel Mack
2009-03-02 14:40         ` Éric Piel
2009-03-01 19:51 ` Robert Hancock
2009-03-02  0:50   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AAD3B1.4050501@tremplin-utc.net \
    --to=eric.piel@tremplin-utc.net \
    --cc=daniel@caiaq.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.