Re: [PATCH] FAT, UFS and mtime

[phcoder <phcoder@gmail.com>]

Bean wrote:
> On Mon, Mar 2, 2009 at 12:25 AM, phcoder <phcoder@gmail.com> wrote:
>> Hello all. It seems that gcc has trouble with -m32 when structure is passed
>> as argument. So I replaced that part by a pointer. Also I made some
>> improvements to ufs code to support solaris branch of ufs. I tested it also
>> with freebsd and netbsd's branch and it works fine on it too.
>> As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a patch
>> with all 3 features. If it's really necessary I can split them but it
>> requires a lot of unnecessary work
> 
> Hi,
> 
> Please don't merge patch, it makes it harder to track down bugs later.
>
Actually these patches aren't merged. The problem is that my copyright 
assignment hasn't been signed by FSF yet so uncommited patches 
accumulate in my grub2 tree

 >
> Also, perhaps you should keep datetime.c as it is. I'm planning to
> split the normal mode into separate components, it'd be nice if you
> don't add files to the normal directory.
> 
Feel free to put datetime.c wherever you want

-- 

Regards
Vladimir 'phcoder' Serbinenko