All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: ide_timer_expiry() - shouldn't 'wait' be int?
Date: Mon, 02 Mar 2009 15:18:40 +0100	[thread overview]
Message-ID: <49ABEAC0.40407@gmail.com> (raw)

vi drivers/ide/ide-io.c +906 and note:

void ide_timer_expiry (unsigned long data)
{
	ide_expiry_t *expiry = hwif->expiry;
	...
	unsigned long   wait = -1;
		...
		if (expiry) {
			...
			wait = expiry(drive);
			if (wait > 0) { /* continue */

also note that in include/linux/ide.h:883:

typedef int (ide_expiry_t)(ide_drive_t *);

doesn't this mean that expiry returns int, and wait therefore should
be int as well?

Roel

             reply	other threads:[~2009-03-02 14:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-02 14:18 Roel Kluin [this message]
2009-03-02 14:38 ` ide_timer_expiry() - shouldn't 'wait' be int? Sergei Shtylyov
2009-03-02 14:58   ` Bartlomiej Zolnierkiewicz
2009-03-02 15:17     ` Roel Kluin
2009-03-02 15:29       ` Bartlomiej Zolnierkiewicz
2009-03-02 15:53         ` Sergei Shtylyov
2009-03-05 12:59         ` Bartlomiej Zolnierkiewicz
2009-03-02 15:39     ` Sergei Shtylyov
2009-03-02 15:45       ` Bartlomiej Zolnierkiewicz
2009-03-02 15:45   ` Sergei Shtylyov
2009-03-02 15:51     ` Bartlomiej Zolnierkiewicz
2009-03-02 16:15       ` Bartlomiej Zolnierkiewicz
2009-03-02 14:50 ` Bartlomiej Zolnierkiewicz
2009-03-02 15:43   ` Sergei Shtylyov
2009-03-02 15:51     ` Bartlomiej Zolnierkiewicz
2009-03-02 15:56       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ABEAC0.40407@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.