All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: mchehab@redhat.com
Cc: linux-media@vger.kernel.org
Subject: V4L/DVB: dvb_dmx_swfilter_section_copy_dump() assignment or addition?
Date: Tue, 03 Mar 2009 23:12:36 +0100	[thread overview]
Message-ID: <49ADAB54.5020004@gmail.com> (raw)

vi drivers/media/dvb/dvb-core/dvb_demux.c +214

and note:

static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed,
                                              const u8 *buf, u8 len)
{
	...
        if (sec->tsfeedp + len > DMX_MAX_SECFEED_SIZE) {
		...
                len = DMX_MAX_SECFEED_SIZE - sec->tsfeedp;
		    ^------------shouldn't this be '+='?
        }

	if (len <= 0)
                return 0;

Also note: len cannot be less than 0 since it's an u8.

             reply	other threads:[~2009-03-03 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 22:12 Roel Kluin [this message]
2009-03-04  2:41 ` V4L/DVB: dvb_dmx_swfilter_section_copy_dump() assignment or addition? Andreas Oberritter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ADAB54.5020004@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.