From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] xenfb shared buffer Date: Wed, 04 Mar 2009 13:32:00 +0100 Message-ID: <49AE74C0.4070909@redhat.com> References: <49AD7114.2080002@eu.citrix.com> <49AE329B.9060400@redhat.com> <49AE6FC6.9080307@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49AE6FC6.9080307@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: xen-devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org Stefano Stabellini wrote: > I am OK with these changes but I wouldn't bother removing the 16 and 32 > bpp conversion code even if currently it would never be used. > After all is working and well tested code that may be useful in the > future. Well I killed it intentionally. That way we'll notice for sure if xenfb doesn't share the buffer although it should. Restoring the functionality in case we ever need it again is easy as all the magic is in the BLT() macro anyway. cheers Gerd