diff for duplicates of <49AE96DA.9010208@openwrt.org> diff --git a/a/1.txt b/N1/1.txt index 2ac2703..6a5ab66 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,29 +1,41 @@ -Sujith ?rta: +Sujith =EDrta: > Gabor Juhos wrote: >>>> +#define AR_SREV_5416(_ah) \ ->>>> + (((_ah)->hw_version.macVersion == AR_SREV_VERSION_5416_PCIE) || \ ->>>> + ((_ah)->hw_version.macVersion == AR_SREV_VERSION_5416_PCI)) +>>>> + (((_ah)->hw_version.macVersion =3D=3D AR_SREV_VERSION_5416= +_PCIE) || \ +>>>> + ((_ah)->hw_version.macVersion =3D=3D AR_SREV_VERSION_5416_= +PCI)) >>>> +#define AR_SREV_5416_V20_OR_LATER(_ah) \ ->>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE) || \ +>>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE= +) || \ >>>> + ((AR_SREV_5416(_ah)) && \ ->>>> + ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_20))) +>>>> + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_20))) >>>> +#define AR_SREV_5416_V22_OR_LATER(_ah) \ ->>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE) || \ +>>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE= +) || \ >>>> + ((AR_SREV_5416(_ah)) && \ ->>>> + ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_22))) +>>>> + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_22))) >>>> + ->>> Hm, the 5416_V1, 5416_V2 macros have to check 3 different HW (5416, 9100, 9160). ->> I don't see any 5416_V1 macro here. The AR_SREV_5416 should check the silicon ->> revision of the AR5416 cards only. But if we would be consistent, we should have ->> a _V10_OR_LATER although i don't see where it would be useful. The _V20_OR_LATER ->> and the _V22_OR_LATER macro I proposed above will cover the 9100 and 9160 chips. +>>> Hm, the 5416_V1, 5416_V2 macros have to check 3 different HW (5416,= + 9100, 9160). +>> I don't see any 5416_V1 macro here. The AR_SREV_5416 should check th= +e silicon +>> revision of the AR5416 cards only. But if we would be consistent, we= + should have +>> a _V10_OR_LATER although i don't see where it would be useful. The _= +V20_OR_LATER +>> and the _V22_OR_LATER macro I proposed above will cover the 9100 and= + 9160 chips. >> -> -> I meant the AR_SREV_5416_V20_OR_LATER and AR_SREV_5416_V22_OR_LATER macros. -> Yes, the naming implies that they are meant for AR5416 chipsets only, but they +>=20 +> I meant the AR_SREV_5416_V20_OR_LATER and AR_SREV_5416_V22_OR_LATER m= +acros. +> Yes, the naming implies that they are meant for AR5416 chipsets only,= + but they > do handle AR9100 and AR9160 chipsets. -> -> The proposed macros don't have the AR9100 and AR9160 macVersion checks, no ? +>=20 +> The proposed macros don't have the AR9100 and AR9160 macVersion check= +s, no ? You are right, they don't have such version checks explicitly, but @@ -33,27 +45,33 @@ AR_SREV_VERSION_9160 > AR_SREV_VERSION_5416_PCIE Maybe this looks cleaner: #define AR_SREV_5416_V20_OR_LATER(_ah) \ - (((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100) || \ + (((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100) || \ ((AR_SREV_5416(_ah)) && \ - ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_20))) + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_20))) #define AR_SREV_5416_V22_OR_LATER(_ah) \ - (((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100) || \ + (((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100) || \ ((AR_SREV_5416(_ah)) && \ - ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_22))) + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_22))) or in this form: #define AR_SREV_5416_V20_OR_LATER(_ah) \ (((AR_SREV_5416(_ah)) && \ - ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_20)) || \ - ((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100)) + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_20)) || \ + ((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100)) #define AR_SREV_5416_V22_OR_LATER(_ah) \ (((AR_SREV_5416(_ah)) && \ - ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_22)) || \ - ((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100)) + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_22)) || \ + ((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100)) Regards, Gabor + +-- +To unsubscribe from this list: send the line "unsubscribe linux-wireles= +s" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 7c9125a..06431a3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,37 +3,52 @@ "ref\049AE851B.2070709@openwrt.org\0" "ref\018862.36931.112561.497768@gargle.gargle.HOWL\0" "From\0Gabor Juhos <juhosg@openwrt.org>\0" - "Subject\0[ath9k-devel] [RFC] ath9k: use correct init values for ar9100 devices\0" + "Subject\0Re: [ath9k-devel] [RFC] ath9k: use correct init values for ar9100 devices\0" "Date\0Wed, 04 Mar 2009 15:57:30 +0100\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Sujith <m.sujith@gmail.com>\0" + "Cc\0ath9k-devel@lists.ath9k.org <ath9k-devel@lists.ath9k.org>" + linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org> + " John W. Linville <linville@tuxdriver.com>\0" "\00:1\0" "b\0" - "Sujith ?rta:\n" + "Sujith =EDrta:\n" "> Gabor Juhos wrote:\n" ">>>> +#define AR_SREV_5416(_ah) \\\n" - ">>>> + (((_ah)->hw_version.macVersion == AR_SREV_VERSION_5416_PCIE) || \\\n" - ">>>> + ((_ah)->hw_version.macVersion == AR_SREV_VERSION_5416_PCI))\n" + ">>>> + (((_ah)->hw_version.macVersion =3D=3D AR_SREV_VERSION_5416=\n" + "_PCIE) || \\\n" + ">>>> + ((_ah)->hw_version.macVersion =3D=3D AR_SREV_VERSION_5416_=\n" + "PCI))\n" ">>>> +#define AR_SREV_5416_V20_OR_LATER(_ah) \\\n" - ">>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE) || \\\n" + ">>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE=\n" + ") || \\\n" ">>>> + ((AR_SREV_5416(_ah)) && \\\n" - ">>>> + ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_20)))\n" + ">>>> + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_20)))\n" ">>>> +#define AR_SREV_5416_V22_OR_LATER(_ah) \\\n" - ">>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE) || \\\n" + ">>>> + (((_ah)->hw_version.macVersion > AR_SREV_VERSION_5416_PCIE=\n" + ") || \\\n" ">>>> + ((AR_SREV_5416(_ah)) && \\\n" - ">>>> + ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_22)))\n" + ">>>> + ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_22)))\n" ">>>> +\n" - ">>> Hm, the 5416_V1, 5416_V2 macros have to check 3 different HW (5416, 9100, 9160).\n" - ">> I don't see any 5416_V1 macro here. The AR_SREV_5416 should check the silicon\n" - ">> revision of the AR5416 cards only. But if we would be consistent, we should have\n" - ">> a _V10_OR_LATER although i don't see where it would be useful. The _V20_OR_LATER\n" - ">> and the _V22_OR_LATER macro I proposed above will cover the 9100 and 9160 chips.\n" + ">>> Hm, the 5416_V1, 5416_V2 macros have to check 3 different HW (5416,=\n" + " 9100, 9160).\n" + ">> I don't see any 5416_V1 macro here. The AR_SREV_5416 should check th=\n" + "e silicon\n" + ">> revision of the AR5416 cards only. But if we would be consistent, we=\n" + " should have\n" + ">> a _V10_OR_LATER although i don't see where it would be useful. The _=\n" + "V20_OR_LATER\n" + ">> and the _V22_OR_LATER macro I proposed above will cover the 9100 and=\n" + " 9160 chips.\n" ">>\n" - "> \n" - "> I meant the AR_SREV_5416_V20_OR_LATER and AR_SREV_5416_V22_OR_LATER macros.\n" - "> Yes, the naming implies that they are meant for AR5416 chipsets only, but they\n" + ">=20\n" + "> I meant the AR_SREV_5416_V20_OR_LATER and AR_SREV_5416_V22_OR_LATER m=\n" + "acros.\n" + "> Yes, the naming implies that they are meant for AR5416 chipsets only,=\n" + " but they\n" "> do handle AR9100 and AR9160 chipsets.\n" - "> \n" - "> The proposed macros don't have the AR9100 and AR9160 macVersion checks, no ?\n" + ">=20\n" + "> The proposed macros don't have the AR9100 and AR9160 macVersion check=\n" + "s, no ?\n" "\n" "You are right, they don't have such version checks explicitly, but\n" "\n" @@ -43,29 +58,35 @@ "Maybe this looks cleaner:\n" "\n" "#define AR_SREV_5416_V20_OR_LATER(_ah) \\\n" - "\t(((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100) || \\\n" + "\t(((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100) || \\\n" "\t ((AR_SREV_5416(_ah)) && \\\n" - "\t ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_20)))\n" + "\t ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_20)))\n" "\n" "#define AR_SREV_5416_V22_OR_LATER(_ah) \\\n" - "\t(((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100) || \\\n" + "\t(((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100) || \\\n" "\t ((AR_SREV_5416(_ah)) && \\\n" - "\t ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_22)))\n" + "\t ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_22)))\n" "\n" "or in this form:\n" "\n" "#define AR_SREV_5416_V20_OR_LATER(_ah) \\\n" "\t(((AR_SREV_5416(_ah)) && \\\n" - "\t ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_20)) || \\\n" - "\t ((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100))\n" + "\t ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_20)) || \\\n" + "\t ((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100))\n" "\n" "#define AR_SREV_5416_V22_OR_LATER(_ah) \\\n" "\t(((AR_SREV_5416(_ah)) && \\\n" - "\t ((_ah)->hw_version.macRev >= AR_SREV_REVISION_5416_22)) || \\\n" - "\t ((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9100))\n" + "\t ((_ah)->hw_version.macRev >=3D AR_SREV_REVISION_5416_22)) || \\\n" + "\t ((_ah)->hw_version.macVersion >=3D AR_SREV_VERSION_9100))\n" "\n" "\n" "Regards,\n" - Gabor + "Gabor\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" + "s\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -5ce4cc22776a39d949aeb98309c8a4ad47a2b49e2a4ea4af8b1b52141ccaf51f +979ece60d2aabb07b2871f552ecf63b5ff6b60972ba4855bc3f21b08bca2f0a2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.