From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
stable@kernel.org, josephjang@gmail.com, mrsohn@gmail.com
Subject: Re: [PATCH #upstream-fixes, -stable] ata_piix: add workaround for Samsung DB-P70
Date: Wed, 04 Mar 2009 10:52:13 -0500 [thread overview]
Message-ID: <49AEA3AD.1080309@rtr.ca> (raw)
In-Reply-To: <49ADE934.6080105@kernel.org>
Tejun Heo wrote:
> Hello, Mark.
>
> Mark Lord wrote:
>> A suggestion, then. As a follow-up patch, would it be possible
>> to drop the workaround kludge, and restore the missing SCR access,
>> __after the first time that a drive is detected on that port__?
>
> Hmmm... yeah. Maybe but it would either involve changing ap->ops on
> the fly (which is a big no no) or wrap SCR access such that it returns
> -EOPNOTSUPP if the kludge is in effect.
>
>> This way, there won't be any funny business for cases where
>> the same ID might occur on different (non-botched) hardware ?
>>
>> Probably overkill, though. :)
>
> Missing SCR access doesn't impact direct usage too much, so yeah I
> think it should be fine as it is until there's some evidence that the
> subsystem IDs are in far wider use.
..
Perfectly sensible!
next prev parent reply other threads:[~2009-03-04 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 4:52 [PATCH #upstream-fixes, -stable] ata_piix: add workaround for Samsung DB-P70 Tejun Heo
2009-03-03 13:17 ` Mark Lord
2009-03-04 2:36 ` Tejun Heo
2009-03-04 15:52 ` Mark Lord [this message]
2009-03-13 18:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AEA3AD.1080309@rtr.ca \
--to=liml@rtr.ca \
--cc=jeff@garzik.org \
--cc=josephjang@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mrsohn@gmail.com \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.