From: Randy Dunlap <randy.dunlap@oracle.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] b43: Fix compilation for devices without PCI core
Date: Wed, 04 Mar 2009 08:51:26 -0800 [thread overview]
Message-ID: <49AEB18E.5050901@oracle.com> (raw)
In-Reply-To: <200903041641.11302.mb@bu3sch.de>
Michael Buesch wrote:
> This fixes compilation, if the PCI core is disabled.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
Ack. Thanks.
>
> John, I think this is only needed for the next feature release, as the patch
> that broke that was only merged for next, afaik.
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2009-03-04 16:35:07.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/b43/main.c 2009-03-04 16:36:08.000000000 +0100
> @@ -4176,15 +4176,17 @@ static int b43_wireless_core_init(struct
> hf |= B43_HF_4318TSSI;
> if (phy->radio_rev < 6)
> hf |= B43_HF_VCORECALC;
> }
> if (sprom->boardflags_lo & B43_BFL_XTAL_NOSLOW)
> hf |= B43_HF_DSCRQ; /* Disable slowclock requests from ucode. */
> +#ifdef CONFIG_SSB_DRIVER_PCICORE
> if ((bus->bustype == SSB_BUSTYPE_PCI) &&
> (bus->pcicore.dev->id.revision <= 10))
> hf |= B43_HF_PCISCW; /* PCI slow clock workaround. */
> +#endif
> hf &= ~B43_HF_SKCFPUP;
> b43_hf_write(dev, hf);
>
> b43_set_retry_limits(dev, B43_DEFAULT_SHORT_RETRY_LIMIT,
> B43_DEFAULT_LONG_RETRY_LIMIT);
> b43_shm_write16(dev, B43_SHM_SHARED, B43_SHM_SH_SFFBLIM, 3);
>
--
~Randy
prev parent reply other threads:[~2009-03-04 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 15:41 [PATCH] b43: Fix compilation for devices without PCI core Michael Buesch
2009-03-04 16:51 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AEB18E.5050901@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.