Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC

[Stefan Weil <weil@mail.berlios.de>]

Palle Lyckegaard schrieb:
>
> The patch below solves a problem when building qemu on OpenSolaris/SPARC.
>
> "feature_to_c.sh: test: argument expected"
>
> There seemes to be a problem with how "features_to_c.sh" is started
> from the makefile. On Solaris the shell in /bin/sh is not standards
> compliant according to
> http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view so the patch
> fixes the configure script so a proper sh in located in /usr/xpg4/bin
> when building on OpenSolaris. Other platforms defaults to whatever is
> in the path when configure is running.
>
> Please consider this patch so qemu builds out-of-the-box for
> OpenSolaris...
>
> Best regards
> Palle
>
> ------ start of patch
>
> Index: configure
> ===================================================================
> --- configure   (revision 6657)
> +++ configure   (working copy)
> @@ -34,6 +34,7 @@
>  make="make"
>  install="install"
>  strip="strip"
> +shell="`which sh`"
>
>  # parse CC options first
>  for opt do
> @@ -263,6 +264,7 @@
>  SunOS)
>      solaris="yes"
>      make="gmake"
> +    shell="/usr/xpg4/bin/sh"

This shell is part of package SUNWxcu4. Is this a mandatory or optional
package?
If it is optional, many installations won't provide /usr/xpg4/bin/sh.

Regards

Stefan Weil