From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] ASoC: make ops a pointer in 'struct snd_soc_dai' Date: Wed, 04 Mar 2009 15:32:58 -0600 Message-ID: <49AEF38A.6050802@freescale.com> References: <49AC225D.6090002@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) by alsa0.perex.cz (Postfix) with ESMTP id 8CAF62433C for ; Wed, 4 Mar 2009 22:33:02 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eric Miao Cc: alsa-devel@alsa-project.org, Mark Brown , Liam Girdwood List-Id: alsa-devel@alsa-project.org Eric Miao wrote: > Updated as below, (gzip version attached due to mailing list > mail size limitation). > > From 74a2b6dfff2948d9d04b33d0a02f645f8c12caf7 Mon Sep 17 00:00:00 2001 > From: Eric Miao > Date: Mon, 2 Mar 2009 22:38:31 +0800 > Subject: [PATCH] ASoC: make ops a pointer of 'struct snd_soc_dai' > > Considering the fact that most cpu_dai or codec_dai are using a same > 'snd_soc_dai_ops' for several similar interfaces, 'ops' would be better > made a pointer instead, to make sharing easier and code a bit cleaner. > > The patch below is rather preliminary since the asoc tree is being > actively developed, and this touches almost every piece of code, > (and possibly many others in development need to be changed as > well). Building of all codecs are OK, yet to every SoC, I didn't test > that. > > Signed-off-by: Eric Miao Tested on an MPC8610 HPCD, and it works. That's all I can vouch for, though. Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale