From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Tejun Heo <htejun@gmail.com>, Ingo Molnar <mingo@elte.hu>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vegard Nossum <vegard.nossum@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>
Subject: __virt_addr_valid vs virtual percpu areas
Date: Wed, 04 Mar 2009 14:57:33 -0800 [thread overview]
Message-ID: <49AF075D.9070607@goop.org> (raw)
On i386, __virt_addr_valid() has the test:
if (system_state != SYSTEM_BOOTING && is_vmalloc_addr((void *) x))
return false;
Why is the vmalloc area a valid virtual address while the system is
booting? This is biting me because I need to translate percpu addresses
to pfns, but I only bother doing the full pagetable walk if
virt_addr_valid() is false (otherwise I just use __pa()).
Removing this test doesn't seem to harm anything at first glance. Is
this OK to do in general (and can we quietly set fire to system_state
while we're about it)?
Thanks,
J
next reply other threads:[~2009-03-04 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 22:57 Jeremy Fitzhardinge [this message]
2009-03-04 23:19 ` __virt_addr_valid vs virtual percpu areas Jiri Slaby
2009-03-04 23:48 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF075D.9070607@goop.org \
--to=jeremy@goop.org \
--cc=htejun@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vegard.nossum@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.