From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/6] mount: Fix a bug in the legacy version of nfs_name_to_address()
Date: Wed, 04 Mar 2009 17:59:54 -0500 [thread overview]
Message-ID: <49AF07EA.5080804@RedHat.com> (raw)
In-Reply-To: <20090227200511.11301.33720.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
All 6 patches have been committed...
steved.
Chuck Lever wrote:
> The legacy version of nfs_name_to_address() returned an incorrect
> value for the size of the returned address.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> utils/mount/network.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/utils/mount/network.c b/utils/mount/network.c
> index 92f75b4..b41388e 100644
> --- a/utils/mount/network.c
> +++ b/utils/mount/network.c
> @@ -291,7 +291,7 @@ int nfs_name_to_address(const char *hostname,
> }
>
> memcpy(&sin->sin_addr, hp->h_addr, hp->h_length);
> - *salen = hp->h_length;
> + *salen = sizeof(struct sockaddr_in);
> return 1;
> }
> #endif /* HAVE_DECL_AI_ADDRCONFIG */
>
prev parent reply other threads:[~2009-03-04 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 20:05 [PATCH 1/6] mount: Fix a bug in the legacy version of nfs_name_to_address() Chuck Lever
[not found] ` <20090227200511.11301.33720.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2009-02-27 20:05 ` [PATCH 2/6] nfs(5): document new [no]resvport option Chuck Lever
2009-02-27 20:05 ` [PATCH 3/6] " Chuck Lever
2009-02-27 20:05 ` [PATCH 4/6] showmount command: remove legacy RPC logic Chuck Lever
2009-02-27 20:05 ` [PATCH 5/6] nfs-utils: Remove fprintf() call from support/nfs/getport.c Chuck Lever
2009-02-27 20:05 ` [PATCH 6/6] configure: fix AC_CACHE_VAL warnings on Fedora 10 Chuck Lever
2009-03-04 22:59 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF07EA.5080804@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.