From: Li Zefan <lizf@cn.fujitsu.com>
To: akpm@linux-foundation.org
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
a.p.zijlstra@chello.nl, menage@google.com
Subject: Re: [patch for 2.6.29? 3/3] vfs: add missing unlock in sget()
Date: Thu, 05 Mar 2009 09:58:43 +0800 [thread overview]
Message-ID: <49AF31D3.7060109@cn.fujitsu.com> (raw)
In-Reply-To: <200903042012.n24KCWhC030028@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Li Zefan <lizf@cn.fujitsu.com>
>
> In sget(), destroy_super(s) is called with s->s_umount held, which makes
> lockdep unhappy.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Paul Menage <menage@google.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
I think it's for 2.6.29, otherwise I can hit a warning with mainline
kernel using the test program which is designed to test cgroups:
=========================
[ BUG: held lock freed! ]
-------------------------
mount/13413 is freeing memory e767a800-e767abff, with a lock still held there!
(&type->s_umount_key#29/1){--..}, at: [<c04a4104>] sget+0x1ea/0x324
2 locks held by mount/13413:
#0: (&type->s_umount_key#29/1){--..}, at: [<c04a4104>] sget+0x1ea/0x324
#1: (&type->s_umount_key#30){--..}, at: [<c04a3f72>] sget+0x58/0x324
stack backtrace:
Pid: 13413, comm: mount Not tainted 2.6.29-rc4 #548
Call Trace:
[<c044d865>] debug_check_no_locks_freed+0xc9/0x105
[<c049c86d>] kfree+0x82/0xd1
[<c04a41e0>] ? sget+0x2c6/0x324
[<c04a41e0>] sget+0x2c6/0x324
[<c045dda9>] ? cgroup_set_super+0x0/0x3e
[<c045cf6f>] ? cgroup_test_super+0x0/0x2f
[<c045f840>] cgroup_get_sb+0x8d/0x284
[<c0489216>] ? kstrdup+0x31/0x53
[<c04a46aa>] vfs_kern_mount+0x40/0x7b
[<c04a4733>] do_kern_mount+0x37/0xbf
[<c04b5dc6>] do_mount+0x5c4/0x61b
[<c04b477a>] ? copy_mount_options+0x2c/0x111
[<c04b5e86>] sys_mount+0x69/0xa0
[<c0403351>] sysenter_do_call+0x12/0x31
prev parent reply other threads:[~2009-03-05 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 20:12 [patch for 2.6.29? 3/3] vfs: add missing unlock in sget() akpm
2009-03-05 1:58 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF31D3.7060109@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=menage@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.