All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Ma <tao.ma@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2: reserve xattr block for new directory with inline data
Date: Thu, 05 Mar 2009 11:17:14 +0800	[thread overview]
Message-ID: <49AF443A.4040305@oracle.com> (raw)
In-Reply-To: <1236222358-10447-1-git-send-email-tiger.yang@oracle.com>

Hi tiger,
	I guess Joel's idea is that you add comment above the code. Not in the 
commit log. ;)

Regards,
Tao

Tiger Yang wrote:
> If this is a new directory with inline data, we choose to reserve
> the entire inline area for directory contents and force an external
> xattr block.
> 
> Signed-off-by: Tiger Yang <tiger.yang@oracle.com>
> ---
>  fs/ocfs2/xattr.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
> index 4ddd788..053ae3d 100644
> --- a/fs/ocfs2/xattr.c
> +++ b/fs/ocfs2/xattr.c
> @@ -549,6 +549,7 @@ int ocfs2_calc_xattr_init(struct inode *dir,
>  	 * for them is ok.
>  	 */
>  	if (dir->i_sb->s_blocksize == OCFS2_MIN_BLOCKSIZE ||
> +	    (S_ISDIR(mode) && ocfs2_supports_inline_data(osb)) ||
>  	    (s_size + a_size) > OCFS2_XATTR_FREE_IN_IBODY) {
>  		ret = ocfs2_reserve_new_metadata_blocks(osb, 1, xattr_ac);
>  		if (ret) {

  reply	other threads:[~2009-03-05  3:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05  3:02 [Ocfs2-devel] [PATCH 0/2] ocfs2: two bug fixes about xattr and inline-data V2 Tiger Yang
2009-03-05  3:05 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: reserve xattr block for new directory with inline data Tiger Yang
2009-03-05  3:17   ` Tao Ma [this message]
2009-03-05 23:30     ` Joel Becker
2009-03-06  2:19       ` Tiger Yang
2009-03-06  2:36         ` Joel Becker
2009-03-05  3:06 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: tweak to get the maximum inline data size with xattr Tiger Yang
2009-03-05 23:32   ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AF443A.4040305@oracle.com \
    --to=tao.ma@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.