All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: blaschka@linux.vnet.ibm.com, bart@jukie.net,
	greearb@candelatech.com, shemminger@vyatta.com,
	dada1@cosmosbay.com, frank.blaschka@de.ibm.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression
Date: Thu, 05 Mar 2009 10:09:18 +0100	[thread overview]
Message-ID: <49AF96BE.1020302@trash.net> (raw)
In-Reply-To: <49AF9672.50200@trash.net>

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Patrick McHardy wrote:
> Yes, but that patch introduced the requirement to pass the correct
> device down since now the handlers need it to get to the ops of the
> underlying device. Previously they all relied on the handlers not
> using their private data.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
>   

Oops, the last patch was broken.



[-- Attachment #2: x --]
[-- Type: text/plain, Size: 521 bytes --]

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 9fb3883..e0578fe 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4113,7 +4113,7 @@ static int bond_neigh_setup(struct net_device *dev, struct neigh_parms *parms)
 		const struct net_device_ops *slave_ops
 			= slave->dev->netdev_ops;
 		if (slave_ops->ndo_neigh_setup)
-			return slave_ops->ndo_neigh_setup(dev, parms);
+			return slave_ops->ndo_neigh_setup(slave->dev, parms);
 	}
 	return 0;
 }

  reply	other threads:[~2009-03-05  9:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-28 18:05 [BUG] 2.6.29-rc* QinQ vlan trunking regression Bart Trojanowski
2009-02-28 18:05 ` Bart Trojanowski
2009-03-04  7:43 ` David Miller
2009-03-04  9:57   ` Patrick McHardy
2009-03-04 10:59     ` David Miller
2009-03-04 11:45       ` Patrick McHardy
2009-03-05  3:53         ` David Miller
2009-03-05  4:54           ` Bart Trojanowski
2009-03-05  4:59             ` Bart Trojanowski
2009-03-05  5:51               ` Patrick McHardy
2009-03-05  5:21             ` David Miller
2009-03-05  5:51           ` Patrick McHardy
2009-03-05  6:57             ` David Miller
2009-03-05  7:00               ` David Miller
2009-03-05  7:05                 ` Patrick McHardy
2009-03-05  7:11                   ` David Miller
2009-03-05  7:12                     ` Patrick McHardy
2009-03-05  7:19                       ` David Miller
2009-03-05  7:26                         ` Patrick McHardy
2009-03-05  7:31                           ` Patrick McHardy
2009-03-05  7:45                             ` David Miller
2009-03-05  8:05                             ` Frank Blaschka
2009-03-05  8:27                               ` Patrick McHardy
2009-03-05  8:56                                 ` David Miller
2009-03-05  8:59                                   ` David Miller
2009-03-05  9:08                                     ` Patrick McHardy
2009-03-05  9:09                                       ` Patrick McHardy [this message]
2009-03-05  9:58                                         ` David Miller
2009-03-05 12:30           ` Maxime Bizon
2009-03-05 12:55             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AF96BE.1020302@trash.net \
    --to=kaber@trash.net \
    --cc=bart@jukie.net \
    --cc=blaschka@linux.vnet.ibm.com \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=frank.blaschka@de.ibm.com \
    --cc=greearb@candelatech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.