From: Benny Halevy <bhalevy@panasas.com>
To: "Jörg-Volker Peetz" <jvpeetz@web.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: &&//|| typo ?
Date: Thu, 05 Mar 2009 11:30:36 +0200 [thread overview]
Message-ID: <49AF9BBC.6090609@panasas.com> (raw)
In-Reply-To: <gncm7q$gp8$1@ger.gmane.org>
On Feb. 16, 2009, 23:35 +0200, Jörg-Volker Peetz <jvpeetz@web.de> wrote:
> Hi,
>
> inspired by the mail http://lkml.org/lkml/2009/2/15/159
> I did
>
> grep -Ern '\!=.*\|\|.*\!=' linux-2.6.28.5
>
> and found the following tests which are always true if the tested variable is
> not NaN:
>
> linux-2.6.28.5/sound/pci/au88x0/au88x0_core.c:2792: if ((bits != 8) || (bits != 16))
>
> linux-2.6.28.5/sound/oss/ad1848.c:283: if ( (devc->model != MD_1845) ||
> (devc->model != MD_1845_SSCAPE))
> linux-2.6.28.5/sound/oss/ad1848.c:2110: if (devc->model != MD_1845 ||
> devc->model != MD_1845_SSCAPE)
>
> linux-2.6.28.5/arch/x86/kvm/vmx.c:1794: if ((ss.type != 3) || (ss.type != 7))
> linux-2.6.28.5/arch/x86/kvm/vmx.c:1837: if ((tr.type != 3) || (tr.type != 11))
> /* TODO: Check if guest is in IA32e mode */
>
> linux-2.6.28.5/net/sunrpc/auth_unix.c:122: if (cred->uc_uid != acred->uid ||
> cred->uc_gid != acred->gid)
This is OK. The left leg compares uids and the right one - gids.
>
> linux-2.6.28.5/net/sunrpc/svcauth_unix.c:747: if (svc_getu32(argv) !=
> htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {
> linux-2.6.28.5/net/sunrpc/svcauth_unix.c:833: if (svc_getu32(argv) !=
> htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {
These two are fine since svc_getu32 will get the next u32
from the argv kvec every time it's being called.
Benny
>
> linux-2.6.28.5/net/sunrpc/auth_gss/gss_krb5_seqnum.c:78: if ((plain[4] !=
> plain[5]) || (plain[4] != plain[6])
> linux-2.6.28.5/net/sunrpc/auth_gss/gss_krb5_seqnum.c:79: || (plain[4] !=
> plain[7]))
>
> linux-2.6.28.5/drivers/block/paride/pf.c:569: if ((buf[k + offs] != 0x20) ||
> (buf[k + offs] != l))
>
> already known:
>
> linux-2.6.28.5/drivers/block/paride/pg.c:425: if (c != ' ' || c != l)
>
> linux-2.6.28.5/drivers/block/paride/pt.c:506: if ((buf[k + offs] != 0x20) ||
> (buf[k + offs] != l))
>
> linux-2.6.28.5/drivers/misc/sgi-gru/grukservices.c:612: if (word0 != word1 ||
> word0 != MAGIC) {
>
> linux-2.6.28.5/drivers/scsi/gvp11.c:283: if (qq != q || qq != 0xff) /* should be
> read only, all 1's */
>
> linux-2.6.28.5/drivers/scsi/FlashPoint.c:6045: if(bit_cnt != 0 || bit_cnt != 8)
>
prev parent reply other threads:[~2009-03-05 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 21:35 &&//|| typo ? Jörg-Volker Peetz
2009-02-17 7:04 ` Takashi Iwai
2009-02-17 15:07 ` roel kluin
2009-03-05 9:30 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF9BBC.6090609@panasas.com \
--to=bhalevy@panasas.com \
--cc=jvpeetz@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.