diff for duplicates of <49AFACC4.4060500@openwrt.org> diff --git a/a/1.txt b/N1/1.txt index 281537c..13b011d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,9 @@ -Sujith ?rta: +Sujith =EDrta: > Gabor Juhos wrote: >> Well, I was curious, so I did it. :) >> ->> After some cut&paste job, here is the diff between the original and the new +>> After some cut&paste job, here is the diff between the original and = +the new >> initvals from your patch: >> >> diff --git a/drivers/net/wireless/ath9k/initvals.h @@ -10,7 +11,7 @@ Sujith ?rta: >> index d492363..d5a8aec 100644 >> --- a/drivers/net/wireless/ath9k/initvals.h >> +++ b/drivers/net/wireless/ath9k/initvals.h ->> @@ -658,7 +657,7 @@ static const u32 ar5416Addac_9100[][2] = { +>> @@ -658,7 +657,7 @@ static const u32 ar5416Addac_9100[][2] =3D { >> {0x0000989c, 0x00000000 }, >> {0x0000989c, 0x00000000 }, >> {0x0000989c, 0x00000000 }, @@ -18,8 +19,8 @@ Sujith ?rta: >> + {0x000098c4, 0x00000000 }, >> }; >> ->> static const u32 ar5416Modes[][6] = { ->> @@ -862,7 +861,7 @@ static const u32 ar5416Common[][2] = { +>> static const u32 ar5416Modes[][6] =3D { +>> @@ -862,7 +861,7 @@ static const u32 ar5416Common[][2] =3D { >> { 0x00008134, 0x00000000 }, >> { 0x00008138, 0x00000000 }, >> { 0x0000813c, 0x00000000 }, @@ -29,33 +30,39 @@ Sujith ?rta: >> { 0x0000816c, 0x00000000 }, >> { 0x00008170, 0x32143320 }, >> -> +>=20 > Heh. :-) > Dunno if those 2 values make any difference. Indeed, these 2 values does not make too much difference. The first one reverts this commit: -http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=6753ddb4bebecab1039a2a2c8d51d6656d0d0513 +http://git.kernel.org/?p=3Dlinux/kernel/git/linville/wireless-testing.g= +it;a=3Dcommitdiff;h=3D6753ddb4bebecab1039a2a2c8d51d6656d0d0513 With the second one we will use the same initial value (which is in the ar5416Common_9100, ar5416Common_9160 ar5416Common_9280_2 and -ar5416Common_9285_1_2 arrays currently) for the AR_PHY_ERR_EIFS_MASK register. +ar5416Common_9285_1_2 arrays currently) for the AR_PHY_ERR_EIFS_MASK re= +gister. -Hm, the ar5416Common_9280 and ar5416Common_9285 arrays are using 0x00000000 for -the same register. By any chance, these values would be wrong in them also? +Hm, the ar5416Common_9280 and ar5416Common_9285 arrays are using 0x0000= +0000 for +the same register. By any chance, these values would be wrong in them a= +lso? -> +>=20 >>>>> +#define AR_SREV_VERSION_9100 0x014 >>>> 0x14? >>> Yep, this can be fixed. >> I have to send a new patch, or you will take care of it? -> +>=20 > Feel free to send a patch fixing this, and the macro cleanup. -> I'll just update the initvals, fix the check for AR9100 in HW attach +> I'll just update the initvals, fix the check for AR9100 in HW attach=20 -Well, the _AR9100_OR_LATER would be the right one, simply the macro itself is -wrong. According to Luis' request, I would send a new patchset, then we can +Well, the _AR9100_OR_LATER would be the right one, simply the macro its= +elf is +wrong. According to Luis' request, I would send a new patchset, then we= + can discuss it further based on that. > and the typo for AR9285 chipsets. @@ -64,3 +71,8 @@ This one can go with a separated patch? Regards, Gabor +-- +To unsubscribe from this list: send the line "unsubscribe linux-wireles= +s" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 0987b76..e602e6b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,16 +6,20 @@ "ref\049AEAA34.8080806@openwrt.org\0" "ref\018863.12192.871072.649460@gargle.gargle.HOWL\0" "From\0Gabor Juhos <juhosg@openwrt.org>\0" - "Subject\0[ath9k-devel] [RFC] ath9k: use correct init values for ar9100 devices\0" + "Subject\0Re: [ath9k-devel] [RFC] ath9k: use correct init values for ar9100 devices\0" "Date\0Thu, 05 Mar 2009 11:43:16 +0100\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Sujith <m.sujith@gmail.com>\0" + "Cc\0ath9k-devel@lists.ath9k.org <ath9k-devel@lists.ath9k.org>" + linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org> + " John W. Linville <linville@tuxdriver.com>\0" "\00:1\0" "b\0" - "Sujith ?rta:\n" + "Sujith =EDrta:\n" "> Gabor Juhos wrote:\n" ">> Well, I was curious, so I did it. :)\n" ">>\n" - ">> After some cut&paste job, here is the diff between the original and the new\n" + ">> After some cut&paste job, here is the diff between the original and =\n" + "the new\n" ">> initvals from your patch:\n" ">>\n" ">> diff --git a/drivers/net/wireless/ath9k/initvals.h\n" @@ -23,7 +27,7 @@ ">> index d492363..d5a8aec 100644\n" ">> --- a/drivers/net/wireless/ath9k/initvals.h\n" ">> +++ b/drivers/net/wireless/ath9k/initvals.h\n" - ">> @@ -658,7 +657,7 @@ static const u32 ar5416Addac_9100[][2] = {\n" + ">> @@ -658,7 +657,7 @@ static const u32 ar5416Addac_9100[][2] =3D {\n" ">> {0x0000989c, 0x00000000 },\n" ">> {0x0000989c, 0x00000000 },\n" ">> {0x0000989c, 0x00000000 },\n" @@ -31,8 +35,8 @@ ">> + {0x000098c4, 0x00000000 },\n" ">> };\n" ">>\n" - ">> static const u32 ar5416Modes[][6] = {\n" - ">> @@ -862,7 +861,7 @@ static const u32 ar5416Common[][2] = {\n" + ">> static const u32 ar5416Modes[][6] =3D {\n" + ">> @@ -862,7 +861,7 @@ static const u32 ar5416Common[][2] =3D {\n" ">> { 0x00008134, 0x00000000 },\n" ">> { 0x00008138, 0x00000000 },\n" ">> { 0x0000813c, 0x00000000 },\n" @@ -42,33 +46,39 @@ ">> { 0x0000816c, 0x00000000 },\n" ">> { 0x00008170, 0x32143320 },\n" ">>\n" - "> \n" + ">=20\n" "> Heh. :-)\n" "> Dunno if those 2 values make any difference.\n" "\n" "Indeed, these 2 values does not make too much difference.\n" "\n" "The first one reverts this commit:\n" - "http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=6753ddb4bebecab1039a2a2c8d51d6656d0d0513\n" + "http://git.kernel.org/?p=3Dlinux/kernel/git/linville/wireless-testing.g=\n" + "it;a=3Dcommitdiff;h=3D6753ddb4bebecab1039a2a2c8d51d6656d0d0513\n" "\n" "With the second one we will use the same initial value (which is in the\n" "ar5416Common_9100, ar5416Common_9160 ar5416Common_9280_2 and\n" - "ar5416Common_9285_1_2 arrays currently) for the AR_PHY_ERR_EIFS_MASK register.\n" + "ar5416Common_9285_1_2 arrays currently) for the AR_PHY_ERR_EIFS_MASK re=\n" + "gister.\n" "\n" - "Hm, the ar5416Common_9280 and ar5416Common_9285 arrays are using 0x00000000 for\n" - "the same register. By any chance, these values would be wrong in them also?\n" + "Hm, the ar5416Common_9280 and ar5416Common_9285 arrays are using 0x0000=\n" + "0000 for\n" + "the same register. By any chance, these values would be wrong in them a=\n" + "lso?\n" "\n" - "> \n" + ">=20\n" ">>>>> +#define AR_SREV_VERSION_9100\t\t0x014\n" ">>>> 0x14?\n" ">>> Yep, this can be fixed.\n" ">> I have to send a new patch, or you will take care of it?\n" - "> \n" + ">=20\n" "> Feel free to send a patch fixing this, and the macro cleanup.\n" - "> I'll just update the initvals, fix the check for AR9100 in HW attach \n" + "> I'll just update the initvals, fix the check for AR9100 in HW attach=20\n" "\n" - "Well, the _AR9100_OR_LATER would be the right one, simply the macro itself is\n" - "wrong. According to Luis' request, I would send a new patchset, then we can\n" + "Well, the _AR9100_OR_LATER would be the right one, simply the macro its=\n" + "elf is\n" + "wrong. According to Luis' request, I would send a new patchset, then we=\n" + " can\n" "discuss it further based on that.\n" "\n" "> and the typo for AR9285 chipsets.\n" @@ -76,6 +86,11 @@ "This one can go with a separated patch?\n" "\n" "Regards,\n" - Gabor + "Gabor\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" + "s\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -feca213c79f341fb6072c9fae87853ae20728e6e1e634155c17e7b9190fe8ccf +df33a9333f100c76109586a85b231780c1502d72ce2b59b9e1d40cde380df660
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.