From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
Vegard Nossum <vegard.nossum@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86: clean up use of system_state in virt_addr_valid and co
Date: Thu, 05 Mar 2009 14:57:52 -0800 [thread overview]
Message-ID: <49B058F0.3010405@goop.org> (raw)
In-Reply-To: <49B04CBE.9080308@gmail.com>
Jiri Slaby wrote:
> On 5.3.2009 03:15, Jeremy Fitzhardinge wrote:
>> x86-32: use specific __vmalloc_start_set flag in __virt_addr_valid
>> x86-64: pre-initialize boot_cpu_data.x86_phys_bits to avoid system_state
>> tests
>
> Looks good, thanks. Just an idea, wouldn't make sense to add the check
> directly into is_vmalloc_addr?
I thought about it, but I think its simply invalid to call
is_vmalloc_addr() until you can meaningfully have vmalloc addresses. It
would be nice to have some way to warn about callers who are using these
predicates in a meaningless way, but there doesn't appear to be any
sensible way to do so (I guess the case I'm concerned about is people
using VMALLOC_START for something before it is meaningful).
J
prev parent reply other threads:[~2009-03-05 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 2:15 [GIT PULL] x86: clean up use of system_state in virt_addr_valid and co Jeremy Fitzhardinge
2009-03-05 13:59 ` Ingo Molnar
2009-03-05 22:05 ` Jiri Slaby
2009-03-05 22:57 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B058F0.3010405@goop.org \
--to=jeremy@goop.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vegard.nossum@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.