Re: Design document of Kemari

[Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>]

Keir,

Thanks for your quick review.
I'm glad my messages have finally reached to the list.

Although the issues you pointed out here aren't fixed yet, let me post the 
divided patches which are updated a little. We'll keep up cleaning and updating 
the code.

Yoshi

Keir Fraser wrote:
> On 02/03/2009 13:30, "Yoshiaki Tamura" <tamura.yoshiaki@lab.ntt.co.jp>
> wrote:
> 
>> You can also get the undivided patches from the following links.
>> http://www.osrg.net/kemari/download/kemari-v1-xen-20081120.patch
>> http://www.osrg.net/kemari/download/kemari-v1-linux-20081120.patch
> 
> The two obvious things I note are the duplicated save/restore functions,
> which will simply bitrot, and the additions to evtchn.c. In particular the
> hack to relax a validity check in evtchn_bind_interdomain() looks pretty
> suspicious. Apart from that there are various spurious white-space and
> debug-tracing changes which I assume you would clean up anyway. Those are
> just the things that jump out from a quick read through.
> 
>  -- Keir
> 
> 
> 
> 
>