All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Milan Broz <mbroz@redhat.com>
Cc: linux-kernel@vger.kernel.org, Alasdair G Kergon <agk@redhat.com>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] Re: Oops using 2.6.28.n after a lazy umount of a crypted loop-device
Date: Fri, 06 Mar 2009 07:16:29 +0100	[thread overview]
Message-ID: <49B0BFBD.7060208@ahsoftware.de> (raw)
In-Reply-To: <49AFBE4A.1010605@redhat.com>

Hello,

thanks for the fast response and patch.

Milan Broz schrieb:
> Please Can you try attached patch if helps here?
> (Patch is not perfect, but should help, at least identify that
> it is the same problem I am fixing:-)

The patch works (I had to add an #include <linux/delay.h> /* msleep */).

I've tested it using 2.6.28.7 and the script below. With your patch the 
script was running over night looping about 400 times without any error. 
A crosscheck without the patch needed only 10 iterations to get an oops. 
So I assume you have fixed the problem I had. ;)

There stills seems to be another problem left, I've got 3 times the 
kernel-message

device-mapper: ioctl: unable to remove open device 
temporary-cryptsetup-21571

during cryptsetup luksOpen. I never realized that msg before, but I've 
found an old one in my logs too.

Anyway, this does not result in an oops, so I'm happy. Thanks a lot.

Kind regards,

Alexander Holler


----------- oopstest.exp -----------------------
!/usr/bin/expect
system modprobe dm-crypt
system modprobe loop
for { set i 0 } { $i < 1000 } {} {
   incr i
   send_user "Test $i\n"
   system losetup /dev/loop1 /Daten/Daten.crypt
   spawn cryptsetup luksOpen /dev/loop1 crypted
   expect passphrase:
   sleep 2
   send oopstest\r
   sleep 60
   send_user \n
   system fsck.ext3 /dev/mapper/crypted
   sleep 2
   system mount -t ext3 -o rw,user,exec,noatime /dev/mapper/crypted 
/Daten/crypted
   system dd if=/dev/urandom of=/Daten/crypted/random bs=1024 count=1024
   system umount -l /Daten/crypted
   system cryptsetup luksClose crypted
   system losetup -d /dev/loop1
}
----------- oopstest.exp -----------------------

  reply	other threads:[~2009-03-06  6:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05 10:11 Oops using 2.6.28.n after a lazy umount of a crypted loop-device Alexander Holler
2009-03-05 11:58 ` [PATCH] " Milan Broz
2009-03-05 11:58   ` Milan Broz
2009-03-06  6:16   ` Alexander Holler [this message]
2009-03-06  8:24     ` Milan Broz
2009-03-06  8:24       ` Milan Broz
2009-03-12 11:51       ` [PATCH] dm crypt: wait for possible unfinished endio() call in destructor Milan Broz
2009-03-13 13:53         ` Alasdair G Kergon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B0BFBD.7060208@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbroz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.