From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LgJAe-000750-5V for mharc-grub-devel@gnu.org; Sun, 08 Mar 2009 09:36:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgJAc-00074S-Nn for grub-devel@gnu.org; Sun, 08 Mar 2009 09:35:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgJAb-00073m-7w for grub-devel@gnu.org; Sun, 08 Mar 2009 09:35:58 -0400 Received: from [199.232.76.173] (port=40284 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgJAa-00073h-W5 for grub-devel@gnu.org; Sun, 08 Mar 2009 09:35:57 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:47793 helo=kirsi2.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LgJAZ-00056a-Rk for grub-devel@gnu.org; Sun, 08 Mar 2009 09:35:56 -0400 Received: from [192.168.1.102] (84.248.105.254) by kirsi2.inet.fi (8.5.014) id 49ACED3A0038F0FB for grub-devel@gnu.org; Sun, 8 Mar 2009 15:35:54 +0200 Message-ID: <49B3C9A2.3050101@nic.fi> Date: Sun, 08 Mar 2009 15:35:30 +0200 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090306195735.GA9992@thorin> <20090308130106.GC28707@thorin> In-Reply-To: <20090308130106.GC28707@thorin> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] linux/gfxterm integration X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2009 13:35:59 -0000 Robert Millan wrote: > On Fri, Mar 06, 2009 at 08:57:35PM +0100, Robert Millan wrote: >> This patch integrates the generic Linux loader with gfxterm. The result is >> that graphical mode becomes usable with this loader. Our loader gets the >> screen settings from the video subsystem (as per gfxterm setup), and passes >> them to Linux. >> >> This way GRUB/gfxterm can transition to Linux/fb with no further mode >> setting. Perhaps this can be exploited to make the transition seamless >> by using the same background image in both places, but I haven't explored >> this possibility yet :-) >> >> Note: As the comment in grub/video.h says, struct grub_video_render_target >> didn't really want to be moved. My code only needs to access it to find >> the framebuffer address. Perhaps it'd be better to move this information >> elsewhere? Or split it in a separate structure / getter? > > New patch. This one calls grub_linux_setup_video() from grub_linux32_boot > instead of grub_rescue_cmd_linux. This way it gets the video status we have > when "boot" is issued instead of the one we have when linux is loaded. > > Any comments on my question about struct grub_video_render_target ? Don't like em... Let me think it a bit.