From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
jaswinder@kernel.org, tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perfcounters/core] x86: perf_counter cleanup
Date: Sun, 08 Mar 2009 14:03:32 -0700 [thread overview]
Message-ID: <49B432A4.7010807@zytor.com> (raw)
In-Reply-To: <1236545948.22914.3648.camel@twins>
Peter Zijlstra wrote:
> On Sun, 2009-03-08 at 15:52 +0000, Jaswinder Singh Rajput wrote:
>> Commit-ID: e255357764f92afcafafbd4879b222b8c752065a
>> Gitweb: http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a
>> Author: "Jaswinder Singh Rajput" <jaswinder@kernel.org>
>> AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530
>> Commit: Ingo Molnar <mingo@elte.hu>
>> CommitDate: Sun, 8 Mar 2009 16:26:50 +0100
>>
>> x86: perf_counter cleanup
>>
>> Remove unused variables and duplicate header file.
>
> Why did you commit this?
>
> Until someone from AMD steps up and either tells us they're going to be
> 48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd
> rather try and get the dynamic thing working.
>
That would be good, but there really is absolutely no reason to leave in
variables which are unused in the current code and therefore give a gcc
warning. It's not like adding new declaration is hard.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-03-08 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-e255357764f92afcafafbd4879b222b8c752065a@git.kernel.org>
2009-03-08 20:59 ` [tip:perfcounters/core] x86: perf_counter cleanup Peter Zijlstra
2009-03-08 21:03 ` H. Peter Anvin [this message]
2009-03-08 21:05 ` Ingo Molnar
2009-03-08 10:34 [git-pull -tip] x86:perf_counter cleanup Peter Zijlstra
2009-03-08 15:52 ` [tip:perfcounters/core] x86: perf_counter cleanup Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B432A4.7010807@zytor.com \
--to=hpa@zytor.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.