All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [6684] Fix "info registers" under kvm.
Date: Mon, 09 Mar 2009 11:42:48 +0200	[thread overview]
Message-ID: <49B4E498.6010709@redhat.com> (raw)
In-Reply-To: <27E8D756-2550-4804-BE0D-54002A41E8A6@web.de>

Andreas Färber wrote:
>
> Am 08.03.2009 um 17:10 schrieb Anthony Liguori:
>
>> Jan Kiszka wrote:
>>> I'm just still waiting for a reply from Anthony on how to embed best 
>>> all
>>> the "if (kvm_enabled()) foo();" patterns [2]. [...]
>>
>> I really don't have a great suggestion.  I've been hoping we could 
>> come up with something better than if (kvm_enabled()) foo().  If we 
>> can't, we can't.
>
> What about this pattern:
>
> #define KVM(x) if (kvm_enabled()) { x; }
> KVM(foo());
>
> That would make it shorter to type and allows to #define KVM(x) for 
> the no-KVM case.
>

Need to work out what to do if the function returns a value.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-03-09 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04 21:00 [Qemu-devel] [6684] Fix "info registers" under kvm Andrzej Zaborowski
2009-03-08 15:56 ` [Qemu-devel] " Jan Kiszka
2009-03-08 16:10   ` Anthony Liguori
2009-03-08 16:32     ` Jan Kiszka
2009-03-08 16:40       ` Anthony Liguori
2009-03-09  7:46         ` Gerd Hoffmann
2009-03-08 16:35     ` Andreas Färber
2009-03-09  9:42       ` Avi Kivity [this message]
2009-03-08 16:18   ` Avi Kivity
2009-03-08 16:23     ` Avi Kivity
2009-03-08 16:36       ` Blue Swirl
2009-03-09  9:42         ` Avi Kivity
2009-03-08 16:36       ` Anthony Liguori
2009-03-09  9:41         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B4E498.6010709@redhat.com \
    --to=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.