From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chrissie Caulfield Date: Mon, 09 Mar 2009 10:01:46 +0000 Subject: [Cluster-devel] [PATCH] dlm: Allow large nodeids In-Reply-To: <20090306205101.GA14003@redhat.com> References: <497EE591.2070607@redhat.com> <497EF10A.8070201@redhat.com> <20090127200630.GA28103@redhat.com> <20090127201919.GB28103@redhat.com> <49804127.8070704@redhat.com> <20090306205101.GA14003@redhat.com> Message-ID: <49B4E90A.5000506@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit David Teigland wrote: > On Wed, Jan 28, 2009 at 11:27:35AM +0000, Chrissie Caulfield wrote: >> David Teigland wrote: >>> On Tue, Jan 27, 2009 at 02:06:30PM -0600, David Teigland wrote: >>>> On Tue, Jan 27, 2009 at 11:33:30AM +0000, Chrissie Caulfield wrote: >>>>> This an updated patch that uses hlists rather than list_heads to save >>>>> memory in the connection structure. > > This patch (with fix) seems to cause the following about half of the time when > killing dlm_controld: I thought you were going to change the iterator in foreach_conn to use hlist_for_each_entry_safe() ? My guess is that the connection is being freed by free_conn and messing up the list. Chrissie