All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Boris Derzhavets <bderzhavets@yahoo.com>,
	Xen-devel <xen-devel@lists.xensource.com>,
	"Marc - A. Dahlhaus [ Administration | Westermann GmbH ]"
	<mad@wol.de>
Subject: Re: [PATCH] xen: mask XSAVE in cpuid since we don't allowguests to use it
Date: Mon, 09 Mar 2009 11:26:33 +0000	[thread overview]
Message-ID: <49B50AF9.76E4.0078.0@novell.com> (raw)
In-Reply-To: <49B35829.1010403@goop.org>

>>> Jeremy Fitzhardinge <jeremy@goop.org> 08.03.09 06:31 >>>
>Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow guests to
>use it (by setting cr4.OSXSAVE).

I actually disagree to this. The kernel should be dealing with the situation
by inspecting the OSXSAVE bit in CPUID when running under Xen, since it's
really Xen that's the 'OS' for that particular feature.

Then, once Keir gets willing to take Intel xsave patch(es), no further change
is going to be needed here. And the same kernel will work (assuming it has
no other dependencies) on older Xen not having this bit masked.

Jan

  parent reply	other threads:[~2009-03-09 11:26 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-08  5:31 [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it Jeremy Fitzhardinge
2009-03-08  8:52 ` Boris Derzhavets
2009-03-08  9:13 ` Keir Fraser
2009-03-09 11:31   ` [PATCH] xen: mask XSAVE in cpuid since we don'tallow " Jan Beulich
2009-03-09 11:45     ` Keir Fraser
2009-03-09 11:18 ` [PATCH] xen: mask XSAVE in cpuid since we don't allow " Boris Derzhavets
2009-03-09 11:26   ` Keir Fraser
2009-03-09 14:31     ` Boris Derzhavets
2009-03-10 22:24       ` Boris Derzhavets
2009-03-11  0:29         ` Jeremy Fitzhardinge
2009-03-11  7:26           ` Boris Derzhavets
2009-03-11  8:40             ` Boris Derzhavets
2009-03-11  9:09               ` Attempt to install SNV_106 under Suse's 2.6.27 xen-ified kernel & Xen Unstable Boris Derzhavets
2009-03-11 11:36               ` Re: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it Boris Derzhavets
2009-03-11 16:09                 ` Jeremy Fitzhardinge
2009-03-11 16:27                   ` Boris Derzhavets
2009-03-11 16:50                     ` Jeremy Fitzhardinge
2009-03-11 16:57                       ` Boris Derzhavets
2009-03-11 17:04                         ` Jeremy Fitzhardinge
2009-03-11 17:21                           ` Boris Derzhavets
2009-03-11 17:43                           ` Boris Derzhavets
2009-03-11 17:47                             ` Jeremy Fitzhardinge
2009-03-11 19:49                               ` Boris Derzhavets
2009-03-12  0:41                                 ` Jeremy Fitzhardinge
2009-03-13 14:39                           ` Boris Derzhavets
2009-03-13 15:20                             ` Jeremy Fitzhardinge
2009-03-13 15:46                               ` Hot plug scripts not working c/s 19355 (was: Re: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it) Dan Magenheimer
2009-03-13 16:05                                 ` Hot plug scripts not working c/s 19355 Jeremy Fitzhardinge
2009-03-13 16:59                                 ` Hot plug scripts not working c/s 19355 (was: Re: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it) Keir Fraser
2009-03-13 17:09                                   ` Jeremy Fitzhardinge
2009-03-13 18:15                                     ` Boris Derzhavets
2009-03-13 18:49                                     ` Andrew Lyon
2009-03-13 19:08                                       ` Boris Derzhavets
2009-03-16 17:17                                     ` Dan Magenheimer
2009-03-16 18:00                                       ` Hot plug scripts not working c/s 19355 Jeremy Fitzhardinge
2009-03-11 19:13                     ` Re: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it Andrew Lyon
2009-03-12  1:21                       ` Jeremy Fitzhardinge
2009-03-12  1:54                         ` Jeremy Fitzhardinge
2009-03-12  8:48                           ` Boris Derzhavets
2009-03-12  8:55                       ` Andrew Lyon
2009-03-12  9:34                         ` Keir Fraser
2009-03-12 12:36                           ` Boris Derzhavets
2009-03-09 11:26 ` Jan Beulich [this message]
2009-03-09 11:29   ` [PATCH] xen: mask XSAVE in cpuid since we don't allowguests " Keir Fraser
2009-03-09 16:40     ` Jeremy Fitzhardinge
2009-03-09 17:54       ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B50AF9.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=bderzhavets@yahoo.com \
    --cc=jeremy@goop.org \
    --cc=keir.fraser@eu.citrix.com \
    --cc=mad@wol.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.