From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Xiaowei" <xiaowei.yang@intel.com>
Subject: Re: [PATCH] allow VM configuration with both sdl=1 and
	vnc=1
Date: Tue, 10 Mar 2009 11:32:50 +0800
Message-ID: <49B5DF62.6060004@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,
HVM can't boot up with sdl this week. I found it's caused by one section 
of this patch (see below). With it Qemu exits because of unrecognized 
option (-sdl). I'm not familiar with vfb. Can you check it's necessary?

Thanks,
xiaowei


diff -r ec3d0937095d -r 0942baa2a088 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py    Fri Mar 06 19:10:29 2009 +0000
+++ b/tools/python/xen/xend/image.py    Fri Mar 06 19:13:23 2009 +0000
@@ -335,11 +336,12 @@ class ImageHandler:
              if int(vnc_config.get('vncunused', 1)) != 0:
                  ret.append('-vncunused')

-        elif has_sdl:
-            # SDL is default in QEMU.
+        if has_sdl:
+            ret.append('-sdl')
              if int(vmConfig['platform'].get('opengl', opengl)) != 1 :
                  ret.append('-disable-opengl')
-        else:
+
+        if not has_sdl and not has_vnc :
              ret.append('-nographic')

          if int(vmConfig['platform'].get('monitor', 0)) != 0: