From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com,
Peter Harris <git@peter.is-a-geek.org>,
Sebastian Schuberth <sschuberth@gmail.com>
Subject: Re: [PATCH] winansi: support ESC [ K (erase in line)
Date: Tue, 10 Mar 2009 08:15:03 +0100 [thread overview]
Message-ID: <49B61377.90103@viscovery.net> (raw)
In-Reply-To: <e2b19f6c7c50e5b0a652c40b0d8e4947134ed669.1236639280u.git.johannes.schindelin@gmx.de>
Johannes Schindelin schrieb:
> This fixes the last bit of msysGit issue 124 for me:
>
> http://code.google.com/p/msysgit/issues/detail?id=124
>
> which annoyed me one time to many today.
>
> I had an earlier version which was smaller, but pretty hacky, in
> that it checked if fprintf is #define'd in xwrite(), and had
> special handling for that case.
>
> This patch is only slightly hacky, in that it assumes that you do
> not try to output something that ends in an incomplete ESC [
> sequence.
Good that I read mail before I start hacking. I was about to do something
about this in a moment. ;)
> To make use of it during a fetch, write() needs to be overridden, too.
No, that's not necessary with the patch that I'm about to send in a
moment. To replace write() for ANSI emulation really goes too far.
-- Hannes
next prev parent reply other threads:[~2009-03-10 7:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1236639280u.git.johannes.schindelin@gmx.de>
2009-03-10 0:41 ` [PATCH] winansi: support ESC [ K (erase in line) Johannes Schindelin
2009-03-10 7:15 ` Johannes Sixt [this message]
2009-03-10 7:30 ` [PATCH/RFC] recv_sideband: Band #2 always goes to stderr Johannes Sixt
2009-03-10 10:56 ` Johannes Schindelin
2009-03-10 11:11 ` Johannes Sixt
2009-03-10 11:17 ` Johannes Sixt
2009-03-10 11:39 ` Johannes Schindelin
2009-03-10 12:14 ` Johannes Sixt
2009-03-10 12:52 ` Johannes Schindelin
2009-03-10 14:26 ` Johannes Sixt
2009-03-10 14:38 ` Shawn O. Pearce
2009-03-10 14:46 ` Johannes Schindelin
2009-03-10 23:59 ` Junio C Hamano
2009-03-10 14:46 ` Shawn O. Pearce
2009-03-10 15:02 ` Johannes Sixt
2009-03-10 15:07 ` Johannes Schindelin
2009-03-10 15:14 ` Johannes Sixt
2009-03-10 17:35 ` Nicolas Pitre
2009-03-10 16:35 ` Jay Soffian
2009-03-10 17:37 ` Nicolas Pitre
2009-03-10 21:54 ` [PATCH 1/2] recv_sideband: Bands #2 and #3 always go " Johannes Sixt
2009-03-10 21:58 ` [PATCH 2/2] winansi: support ESC [ K (erase in line) Johannes Sixt
2009-03-11 10:22 ` Johannes Schindelin
2009-03-10 11:31 ` [PATCH] " Johannes Schindelin
2009-03-10 12:29 ` Peter Harris
2009-03-10 12:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B61377.90103@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@peter.is-a-geek.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.