From: Antti Palosaari <crope@iki.fi>
To: Richard Hughes <hughsient@gmail.com>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
Peter Hutterer <peter.hutterer@redhat.com>, mjg <mjg@redhat.com>,
linux-input <linux-input@vger.kernel.org>,
Matthias Clasen <mclasen@redhat.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] DVB-USB: correct the comment about KEY_SLEEP
Date: Tue, 10 Mar 2009 12:31:52 +0200 [thread overview]
Message-ID: <49B64198.6050201@iki.fi> (raw)
In-Reply-To: <1236164977.3936.30.camel@hughsie-work.lan>
Richard Hughes wrote:
> On Wed, 2009-03-04 at 10:54 +0000, Richard Hughes wrote:
>> On Mon, 2009-03-02 at 08:24 -0300, Henrique de Moraes Holschuh wrote:
>>> FWIW, I think it is a good idea, and I'd take patches for
>>> thinkpad-acpi.
>> Patch attached for thinkpad-acpi. KEY_HIBERNATE is already in
>> linux-next, but has not yet been pushed to master. Please review,
>> thanks.
>
> Antti, I've included a fix to the Afatech AF9015 DVB-T USB2.0 receiver
> header file. It corrects the comment about KEY_SLEEP. Please review.
It is not correct. Comment "Hibernate" for that button comes from the
remote controller, where "Z^z" is printed to the top of the button and
"Hibernate" below the button. Replacing KEY_SLEEP with KEY_HIBERNATE
seems to be correct solution for me.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2009-03-10 10:31 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 11:13 suspend / hibernate nomenclature Richard Hughes
2009-03-02 11:24 ` Henrique de Moraes Holschuh
2009-03-02 12:11 ` Richard Hughes
2009-03-03 17:20 ` [patch] add KEY_HIBERNATE and clarify the uses of KEY_SUSPEND and KEY_SLEEP Richard Hughes
2009-03-03 19:53 ` Rafael J. Wysocki
2009-03-04 8:42 ` Dmitry Torokhov
2009-03-04 10:54 ` [PATCH] thinkpad-acpi: use correct key names for sleep states in driver Richard Hughes
2009-03-04 10:58 ` [PATCH] panasonic-laptop: " Richard Hughes
2009-03-04 23:58 ` Harald Welte
2009-03-05 9:09 ` Richard Hughes
2009-03-04 11:09 ` [PATCH] DVB-USB: correct the comment about KEY_SLEEP Richard Hughes
2009-03-10 10:31 ` Antti Palosaari [this message]
2009-03-04 12:04 ` [PATCH] thinkpad-acpi: use correct key names for sleep states in driver Henrique de Moraes Holschuh
2009-08-18 20:02 ` Yves-Alexis Perez
2009-08-18 20:10 ` Matthew Garrett
2009-08-18 20:27 ` Yves-Alexis Perez
2009-08-18 20:45 ` Matthew Garrett
2009-08-22 18:02 ` Henrique de Moraes Holschuh
2009-08-19 9:18 ` Ali Abdallah
2009-08-26 11:36 ` Yves-Alexis Perez
2009-08-26 13:43 ` Matthew Garrett
2009-08-26 17:52 ` Yves-Alexis Perez
2009-08-26 22:51 ` Henrique de Moraes Holschuh
2009-08-27 6:18 ` Dmitry Torokhov
2009-08-28 0:34 ` Henrique de Moraes Holschuh
2009-03-07 8:37 ` suspend / hibernate nomenclature Andrey Borzenkov
2009-03-07 15:48 ` Matthew Garrett
2009-03-07 16:41 ` Henrique de Moraes Holschuh
2009-03-07 16:48 ` Matthew Garrett
2009-03-07 17:17 ` Henrique de Moraes Holschuh
2009-03-07 20:25 ` Richard Hughes
2009-03-07 20:39 ` Matthew Garrett
2009-03-08 8:45 ` Richard Hughes
2009-03-08 14:41 ` Matthew Garrett
2009-03-08 20:56 ` Rafael J. Wysocki
2009-03-08 23:07 ` Dmitry Torokhov
2009-03-08 23:19 ` Matthew Garrett
2009-03-09 13:52 ` Ville Syrjälä
2009-03-09 14:00 ` Matthew Garrett
2009-03-09 15:10 ` Ville Syrjälä
2009-03-09 8:31 ` Andrey Borzenkov
2009-03-09 13:26 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B64198.6050201@iki.fi \
--to=crope@iki.fi \
--cc=hughsient@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mclasen@redhat.com \
--cc=mjg@redhat.com \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.