All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, rdreier@cisco.com,
	jirislaby@gmail.com, peterz@infradead.org, will.newton@gmail.com,
	hancockrwd@gmail.com, jeremy@goop.org
Subject: Re: [PATCH v4] introduce macro spin_event_timeout()
Date: Tue, 10 Mar 2009 14:04:50 -0500	[thread overview]
Message-ID: <49B6B9D2.8000807@freescale.com> (raw)
In-Reply-To: <fa686aa40903101141l33fbfc7cha0d2d85f6e1cb795@mail.gmail.com>

Grant Likely wrote:

> I typically use something in the form of this pattern on powerpc code
> when I absolutely have to busywait.
>     int end_ts = get_tbl() + some_delay;  /* note that this is signed */
>     while (end_ts - get_tbl() > 0)
>         if (condition)
>             break;

Funny you mention this, because I was just about to implement the same
thing.  Of course, it will be a PowerPC-only function, but I suppose
that's its fate regardless.

> This macro also looks like a tempting unbounded latency tarpit to fall
> into when people start using it in critical regions,  but that goes
> for code using a non-timed-out busywait also.

I can't fix everything!

-- 
Timur Tabi
Linux kernel developer at Freescale

      reply	other threads:[~2009-03-10 19:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-10 15:30 [PATCH v4] introduce macro spin_event_timeout() Timur Tabi
2009-03-10 15:35 ` Alan Cox
2009-03-10 15:50   ` Timur Tabi
2009-03-10 16:05     ` Will Newton
2009-03-10 16:11       ` Timur Tabi
2009-03-11  0:01   ` Benjamin Herrenschmidt
2009-03-11  0:37     ` Alan Cox
2009-03-11 16:48       ` Timur Tabi
2009-03-11 16:58         ` Alan Cox
2009-03-11 18:18           ` Timur Tabi
2009-03-11 21:58             ` Benjamin Herrenschmidt
2009-03-12  2:45               ` Grant Likely
2009-03-12 15:54                 ` Timur Tabi
2009-03-12 16:01                   ` Grant Likely
2009-03-12 16:19                     ` Timur Tabi
2009-03-12 16:50                       ` Peter Zijlstra
2009-03-12 19:05                         ` Timur Tabi
2009-03-13  3:03                           ` Benjamin Herrenschmidt
2009-03-13  4:51                             ` Grant Likely
2009-03-10 18:41 ` Grant Likely
2009-03-10 19:04   ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B6B9D2.8000807@freescale.com \
    --to=timur@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=hancockrwd@gmail.com \
    --cc=jeremy@goop.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdreier@cisco.com \
    --cc=will.newton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.