All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: "Altobelli, David" <david.altobelli@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tweak spin logic for hpilo
Date: Tue, 10 Mar 2009 17:37:13 -0600	[thread overview]
Message-ID: <49B6F9A9.1030803@gmail.com> (raw)
In-Reply-To: <92D64232F2316045B18937D5C9996B1522834ABED6@GVW1144EXB.americas.hpqcorp.net>

Altobelli, David wrote:
>> From: Andrew Morton
>> David Altobelli wrote:
>>> Change hpilo open and close logic to spin for 10usec between checking
>>> device, rather than every usec.
>> err.. Why?
> 
> Because the loop is coded to take up to 10ms, it seemed prudent to increase
> the interval between polling the device, to reduce the load on the system and
> allow more other work to happen.

You're using udelay, which is a spin loop. Nothing else can happen on 
that CPU while it's delaying anyway.

  reply	other threads:[~2009-03-10 23:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-09 22:56 [PATCH] tweak spin logic for hpilo David Altobelli
2009-03-09 23:04 ` Andrew Morton
2009-03-10 13:42   ` Altobelli, David
2009-03-10 23:37     ` Robert Hancock [this message]
2009-03-10 23:56       ` Alan Cox
2009-03-09 23:14 ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B6F9A9.1030803@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.altobelli@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.