From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LhPUx-0000uC-Qz for mharc-grub-devel@gnu.org; Wed, 11 Mar 2009 10:33:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhPUw-0000sY-57 for grub-devel@gnu.org; Wed, 11 Mar 2009 10:33:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhPUu-0000qc-3d for grub-devel@gnu.org; Wed, 11 Mar 2009 10:33:29 -0400 Received: from [199.232.76.173] (port=43980 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhPUt-0000qO-Ti for grub-devel@gnu.org; Wed, 11 Mar 2009 10:33:27 -0400 Received: from elasmtp-scoter.atl.sa.earthlink.net ([209.86.89.67]:34291) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhPUt-0003Su-I1 for grub-devel@gnu.org; Wed, 11 Mar 2009 10:33:27 -0400 Received: from [24.148.247.139] (helo=[192.168.0.199]) by elasmtp-scoter.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1LhPUq-0004MC-Mt for grub-devel@gnu.org; Wed, 11 Mar 2009 10:33:24 -0400 Message-ID: <49B7CC78.405@earthlink.net> Date: Wed, 11 Mar 2009 10:36:40 -0400 From: BandiPat Organization: Magic Page Products User-Agent: Thunderbird 2.0.0.19 (X11/20081209) MIME-Version: 1.0 To: GRUB 2 References: <498E15D0.4090101@gmail.com> <498E9C26.40407@nic.fi> In-Reply-To: <498E9C26.40407@nic.fi> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-ELNK-Trace: c85a64c14a050764b95206241ab561599ef193a6bfc3dd48f7a1f9b2bf8740f5710a1e447fd112abe925a8e63659b694350badd9bab72f9c350badd9bab72f9c X-Originating-IP: 24.148.247.139 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Subject: Re: [Bugfix] Characters disappearing in gfxterm X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 14:33:30 -0000 Vesa J=C3=A4=C3=A4skel=C3=A4inen wrote: > phcoder wrote: >> Hello. I've run into the bug that when editing menu entry in gfxterm >> characters disappear after cursor moves away from its position. Here i= s >> bugfix >=20 > I don't think this is a clean fix: >=20 >> Index: term/gfxterm.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- term/gfxterm.c (revision 1974) >> +++ term/gfxterm.c (working copy) >> @@ -744,6 +744,8 @@ >> /* Render cursor to text layer. */ >> grub_video_set_active_render_target (text_layer); >> grub_video_fill_rect (color, x, y, width, height); >> + if (! show) >> + write_char (); >> grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPL= AY); >> =20 >> /* Mark cursor to be redrawn. */ >=20 > It is not designed to work in there. I think modifying this needs > logical level approach and not ad hoc fix. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Has there been any further work done on the disappearing characters in=20 gfxterm? I know you guys had looked at it, but the last word was it was = not fixed yet. I understand it's not a priority, but a fix would help=20 in me getting the devs for Zenwalk to approve it's use in the next=20 release version. Also, do you intend to release another stable version soon? As I watch=20 the progress of Grub2, I continue to see a good program get even better, = so using svn is fine for me! You've added so much since the 1.96=20 release though, it just seems another stable release is past due.=20 Continue the great work you're doing though, as good software never=20 truly gets finished! Thanks, Pat --=20 ---Zenwalk v6.0--Linux 2.6.28--- Registered Linux User #225206 "Ever tried Zen computing?" http://www.zenwalk.org