From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mick Jordan Subject: Re: memory_reservation bug? Date: Wed, 11 Mar 2009 12:34:39 -0700 Message-ID: <49B8124F.8010609@Sun.COM> References: Reply-To: Mick.Jordan@sun.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0606985969==" Return-path: In-reply-to: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel-list List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============0606985969== Content-type: multipart/alternative; boundary="Boundary_(ID_XJCkC1TdpxHSJ0xugrBxvA)" This is a multi-part message in MIME format. --Boundary_(ID_XJCkC1TdpxHSJ0xugrBxvA) Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT On 03/11/09 11:08, Keir Fraser wrote: > On 11/03/2009 17:32, "Mick Jordan" wrote: > > >> I've looked at the code in memory.c and page_alloc.c and Xen certainly >> thinks tot_pages > max_pages for the domain when it reports the error. >> >> The extent_order on the reservations is 0. >> >> Any ideas? >> > > Just because you called decrease_reservation() doesn't mean the pages > necessarily really got freed. If you still have mappings to them squirrelled > away then the free can be deferred. > Ah, that explains it, thank you. I was taking the fact that the return value equaled the number I tried to decrease meant that it really did decrease by that amount. But, owing to a bug, I do in fact have mappings still lying around. Xen really does need a developer manual -;) Mick --Boundary_(ID_XJCkC1TdpxHSJ0xugrBxvA) Content-type: text/html; charset=ISO-8859-1 Content-transfer-encoding: 7BIT On 03/11/09 11:08, Keir Fraser wrote: 
On 11/03/2009 17:32, "Mick Jordan" <Mick.Jordan@sun.com> wrote:

  
I've looked at the code in memory.c and page_alloc.c and Xen certainly
thinks tot_pages > max_pages for the domain when it reports the error.

The extent_order on the reservations is 0.

Any ideas?
    

Just because you called decrease_reservation() doesn't mean the pages
necessarily really got freed. If you still have mappings to them squirrelled
away then the free can be deferred.
Ah, that explains it, thank you. I was taking the fact that the return value equaled the number I tried to decrease meant that it really did decrease by that amount. But, owing to a bug, I do in fact have mappings still lying around.

Xen really does need a developer manual -;)

Mick



--Boundary_(ID_XJCkC1TdpxHSJ0xugrBxvA)-- --===============0606985969== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0606985969==--