All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Menage <menage@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Containers <containers@lists.linux-foundation.org>
Subject: [PATCH] debug cgroup: remove unneeded cgroup_lock
Date: Thu, 12 Mar 2009 09:47:35 +0800	[thread overview]
Message-ID: <49B869B7.1090108@cn.fujitsu.com> (raw)

Since we are in cgroup write handler, so the cgrp is valid, so we
don't have to hold cgroup_mutex when calling cgroup_task_count().
One similar example is in cgroup_tasks_open().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/cgroup_debug.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/cgroup_debug.c b/kernel/cgroup_debug.c
index daca620..0c92d79 100644
--- a/kernel/cgroup_debug.c
+++ b/kernel/cgroup_debug.c
@@ -40,9 +40,7 @@ static u64 taskcount_read(struct cgroup *cont, struct cftype *cft)
 {
 	u64 count;
 
-	cgroup_lock();
 	count = cgroup_task_count(cont);
-	cgroup_unlock();
 	return count;
 }
 
-- 
1.5.4.rc3


             reply	other threads:[~2009-03-12  1:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12  1:47 Li Zefan [this message]
2009-03-12  2:43 ` [PATCH] debug cgroup: remove unneeded cgroup_lock Paul Menage
2009-03-12  2:49   ` Li Zefan
     [not found]   ` <6599ad830903111943u2799333dh680470f9daa6ccbb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-03-12  2:49     ` Li Zefan
     [not found] ` <49B869B7.1090108-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-03-12  2:43   ` Paul Menage
  -- strict thread matches above, loose matches on Subject: below --
2009-03-12  1:47 Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B869B7.1090108@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.