From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LhjaP-0004nZ-Nr for mharc-grub-devel@gnu.org; Thu, 12 Mar 2009 08:00:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhjaM-0004lg-VY for grub-devel@gnu.org; Thu, 12 Mar 2009 08:00:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhjaL-0004kU-3S for grub-devel@gnu.org; Thu, 12 Mar 2009 08:00:26 -0400 Received: from [199.232.76.173] (port=49972 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhjaK-0004kP-TW for grub-devel@gnu.org; Thu, 12 Mar 2009 08:00:24 -0400 Received: from mail-fx0-f176.google.com ([209.85.220.176]:42547) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhjaK-0005Og-9p for grub-devel@gnu.org; Thu, 12 Mar 2009 08:00:24 -0400 Received: by fxm24 with SMTP id 24so379127fxm.42 for ; Thu, 12 Mar 2009 05:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=DciO9FGpw20weqhMiukgjWgv5ZJSm4aYkWrFEsnOOvI=; b=TYPWD/GqXUPYOh6e45VufMJ9clqQqQDKMGh1YPPR9wuj0/5CVju1POz4xmf+iTTeCp oD4Z5XoiFImRwUO/nr0FV2z3upRcRdieimLrCOMRe1GitlWubKNUxcBT9pl8s5F1Mwh4 sujbHKNG0LmEG8tYPzE1FhvO11FikOtyb1gF0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=iTkJ2PjgYGIZBAvjoIozx5a/VVkcYJIgZKYjQRJravQEj933H7fgu4Nzz1lgZ3V5Ah dqP4gAgGnJLLpoDVXt1hRcRUXqtSG62cGOQlINMu2roaRXbKLd5XBHVHlkKlKDfivL7F fPA1YbrEfAv2etfeeUBRPOKtRUL0TktduCtoY= Received: by 10.223.126.145 with SMTP id c17mr7235653fas.102.1236859223050; Thu, 12 Mar 2009 05:00:23 -0700 (PDT) Received: from ?82.130.80.49? (hg-public-dock-49-dhcp.ethz.ch [82.130.80.49]) by mx.google.com with ESMTPS id 12sm869174fks.25.2009.03.12.05.00.22 (version=SSLv3 cipher=RC4-MD5); Thu, 12 Mar 2009 05:00:22 -0700 (PDT) Message-ID: <49B8F957.7080203@gmail.com> Date: Thu, 12 Mar 2009 13:00:23 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <4992A884.4050406@gmail.com> <4992AAD9.2020200@gmail.com> In-Reply-To: <4992AAD9.2020200@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] remove bsd asm helper functions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2009 12:00:27 -0000 Hello. Now I noticed that the helper are still necessary when booting i386 kernel on efi-x86_64. I would like this code to be uniform accross i386 branches so please don't commit this patch it will be soon superseed by my next work phcoder wrote: > Sorry, forgot changelog entry. Here it is: > 2009-02-11 Vladimir Serbinenko > > Move BSD helper out of kernel > > * conf/i386-pc.rmk: Add loader/i386/bsd_helper.S to _bsd.mod > * kern/i386/loader.S: Removed BSD helpers > * include/grub/i386/loader.h: Removed declaration of > grub_unix_real_boot > * loader/i386/bsd.c (grub_freebsd_boot): Replaced call to > grub_unix_real_boot by direct call of kernel > (grub_netbsd_boot): Likewise > (grub_openbsd_boot): Likewise > > phcoder wrote: >> Hello. Asm helper functions for bsd aren't really needed. Actually BSD >> entry point may be called directly as cdecl function. With this >> approach theese helper functions don't take place in kernel anymore. >> Tested with freebsd, openbsd and netbsd. However my tests were limited >> to launching kernel and see if it complains about not being able to >> mount root. Can someone test it with complete system? >> Thanks >> Vladimir 'phcoder' Serbinenko >> > -- Regards Vladimir 'phcoder' Serbinenko