From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LhlCU-0007Ax-Se for mharc-grub-devel@gnu.org; Thu, 12 Mar 2009 09:43:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhlCT-0007AV-Ez for grub-devel@gnu.org; Thu, 12 Mar 2009 09:43:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhlCS-0007AB-TX for grub-devel@gnu.org; Thu, 12 Mar 2009 09:43:53 -0400 Received: from [199.232.76.173] (port=49109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhlCS-0007A6-RE for grub-devel@gnu.org; Thu, 12 Mar 2009 09:43:52 -0400 Received: from mail-fx0-f176.google.com ([209.85.220.176]:59148) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhlCS-00009M-BM for grub-devel@gnu.org; Thu, 12 Mar 2009 09:43:52 -0400 Received: by fxm24 with SMTP id 24so419325fxm.42 for ; Thu, 12 Mar 2009 06:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=CRgJdETT9ttVbQrowjUc1vTTTzOCTUxAAjOLpgh3h14=; b=JsOyqXNkTlPXaJWh/UpfQtLKU79SLIekA5oAb/V3+wmHcCBHrGfqwIiNypUECFL1PF uXaPJXmuD1A6ev3FuDgpzYrQWyF25oGfcbN/RwnWfzai/lyp3duO+0PaLYl8ntz+twHd OPYZ5u0QXNn5Z6/m2ZSAnWDvrS74HkQ3PFVz0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=qK5IUJAL83KwdhmniEkQMXOGvrDUF/9MCWZpbqRl/qKJVdbohl7rriuEGcvSJGKOF3 1TzlEIYkbRWbtixmIqP8LGHwKnWLXJjrI2yarFfC1PjqdxBwelcdj93opdKDIlZcsH1v txCg1U/bsyrfCYnmcRP8LRnMvoijp65rSSWZw= Received: by 10.103.193.13 with SMTP id v13mr3639mup.1.1236865431172; Thu, 12 Mar 2009 06:43:51 -0700 (PDT) Received: from ?82.130.80.49? (hg-public-dock-49-dhcp.ethz.ch [82.130.80.49]) by mx.google.com with ESMTPS id e9sm1284950muf.38.2009.03.12.06.43.50 (version=SSLv3 cipher=RC4-MD5); Thu, 12 Mar 2009 06:43:50 -0700 (PDT) Message-ID: <49B91197.6050008@gmail.com> Date: Thu, 12 Mar 2009 14:43:51 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: David Miller , The development of GRUB 2 References: <49B8F067.2040503@gmail.com> <20090312.055819.95768237.davem@davemloft.net> <49B90C69.60703@gmail.com> <20090312.062628.260166400.davem@davemloft.net> In-Reply-To: <20090312.062628.260166400.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: Subject: Re: ELF bugfixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2009 13:43:53 -0000 David Miller wrote: > From: phcoder > Date: Thu, 12 Mar 2009 14:21:45 +0100 > >> I knew it but normally when you parse files normally offsets aren't >> guaranteed to be aligned. But now it seems that elf parser is >> written in a way to guarantee at least some alignments. Then this >> part of patch probably is to be dropped or changed to proper aligned >> attribute > > These ELF structures DO NOT need the aligned attribute either. > > Nobody, in any source tree anyways, adds either the aligned > or packed attributes to the core ELF data structures because > they are absolutely not necessary. And this includes source > trees that support basically every CPU type out there. > > Please stop making arbitrary changes, and instead describe on the > mailing list the exact problem you are trying to solve. Then, > implement the solution which you can show is necessary and fully > understand. Actually what I was doing now was discussing. If we don't discuss we may everyone create our own fork. I previously had problems because some of the structures in headers didn't have proper alignment attribute. My problem was that grub2 didn't load solaris kernel. Further it revealed that the problem wasn't the attributes. I fixed the problem (see the rest of my patch) however I decided to submit also that part to prevent potential problems in the future. If you're expert with ELF format and say that this part will never be needed, it's ok with me but please stay respectful and discuss instead of accusing. -- Regards Vladimir 'phcoder' Serbinenko