From: Mike Christie <michaelc@cs.wisc.edu>
To: Abhijeet Joglekar <abjoglek@cisco.com>
Cc: james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, jeykholt@cisco.com
Subject: Re: [RFC][PATCH 5/6] fnic: add descriptor right, buffers, device interface
Date: Thu, 12 Mar 2009 15:43:47 -0500 [thread overview]
Message-ID: <49B97403.4020302@cs.wisc.edu> (raw)
In-Reply-To: <20090228023230.12158.72176.stgit@feynman.nuovasystems.com>
Abhijeet Joglekar wrote:
> diff --git a/drivers/scsi/fnic/vnic_cq.h b/drivers/scsi/fnic/vnic_cq.h
> new file mode 100644
> index 0000000..4ede680
> --- /dev/null
> +++ b/drivers/scsi/fnic/vnic_cq.h
> +
> +/*
> + * These defines avoid symbol clash between fnic and enic (Cisco 10G Eth
> + * Driver) when both are built with CONFIG options =y
> + */
> +#define vnic_cq_service fnic_cq_service
> +#define vnic_cq_free fnic_cq_free
> +#define vnic_cq_alloc fnic_cq_alloc
> +#define vnic_cq_init fnic_cq_init
> +#define vnic_cq_clean fnic_cq_clean
> +
Are these functions implementations the same as the net ones? I only
looked at the first one and it looked the same.
If you are going to share code then you probably want to put them in a
new module that both enic and fnic can use.
Are you going to ask where the module should then live (drivers/net vs
driver/scsi)? I do not know the answer.
next prev parent reply other threads:[~2009-03-12 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 2:31 [PATCH 0/6] FCoE HBA Driver (fnic) for 2.6.30 feature window Abhijeet Joglekar
2009-02-28 2:31 ` [RFC][PATCH 1/6] fnic: add main file with module infrastructure, fnic structure, Makefile Abhijeet Joglekar
2009-03-12 20:13 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 2/6] fnic: add SCSI FCP handling Abhijeet Joglekar
2009-03-12 20:27 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 3/6] fnic: Add support for Fibre Channel Services through libFC Abhijeet Joglekar
2009-03-12 20:36 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 4/6] fnic: adds resource allocation, interupt interfaces Abhijeet Joglekar
2009-02-28 2:32 ` [RFC][PATCH 5/6] fnic: add descriptor right, buffers, device interface Abhijeet Joglekar
2009-03-12 20:43 ` Mike Christie [this message]
2009-03-12 22:10 ` Abhijeet Arvind Joglekar (abjoglek)
2009-03-17 16:41 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 6/6] fnic: Patch MAINTAINERS, scsi Makefile, scsi Kconfig Abhijeet Joglekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B97403.4020302@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=abjoglek@cisco.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.