From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Xiaowei" <xiaowei.yang@intel.com>
Subject: Re: [PATCH] xend: Fix removing /vm/UUID/device paths
	when device cannot be disconnected v2
Date: Fri, 13 Mar 2009 10:42:00 +0800
Message-ID: <49B9C7F8.8010106@intel.com>
References: <49B9C000.3070805@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <49B9C000.3070805@intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jiri Denemark <jdenemar@redhat.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

> This is a corrected version of a patch commited as c/s 19250 and reverted by
> c/s 19314. Thanks to "trap sigerr ERR" in xen-hotplug-common.sh the
> xen-hotplug-cleanup would exit when reading /local/domain/ID/vm fails thus
> skipping all the xenstore-rm lines in the rest of the script. Sorry for the
> troubles the original patch caused...

Hi Jiri,
Did you also notice after claim_lock() returns, the ERR trap handler is 
still "sigerr" instead of the one registered inside claim_lock: 
"release_lock $1; sigerr"? I guess it only takes effect within the scope 
of a function. Can shell experts give an explanation here?:)

If so, claim_lock never works as it meant to be, and we will have 
potential issue as it's widely used.

Thanks,
xiaowei