All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johns Daniel <jdaniel@computer.org>
To: greg@kroah.com
Cc: linuxppc-dev@ozlabs.org, afleming@freescale.com, stable@kernel.org
Subject: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try)
Date: Sat, 14 Mar 2009 10:03:51 -0500	[thread overview]
Message-ID: <49BBC757.7090001@computer.org> (raw)

TSEC/MDIO will not work with older device trees because of a semicolon 
at the end of a macro resulting in an empty for loop body.

This fix only applies to 2.6.28; this code is gone in 2.6.29, according 
to Grant Likely!

Signed-off-by: Johns Daniel <johns.daniel@gmail.com 
<mailto:johns.daniel@gmail.com>>
======================================

--- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig	2009-02-20 16:41:27.000000000 -0600
+++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c	2009-03-14 09:01:38.994630400 -0500
@@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void
		gfar_mdio_of_init_one(np);

	/* try the deprecated version */
-	for_each_compatible_node(np, "mdio", "gianfar");
+	for_each_compatible_node(np, "mdio", "gianfar")
		gfar_mdio_of_init_one(np);

	return 0;

             reply	other threads:[~2009-03-14 15:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-14 15:03 Johns Daniel [this message]
2009-03-15  2:01 ` [PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try) Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BBC757.7090001@computer.org \
    --to=jdaniel@computer.org \
    --cc=afleming@freescale.com \
    --cc=greg@kroah.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.