From: David Newall <davidn@davidnewall.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Screwy arch/x86/include/asm/string_32.h
Date: Sun, 15 Mar 2009 02:36:49 +1030 [thread overview]
Message-ID: <49BBD619.6050809@davidnewall.com> (raw)
There's a lot of weirdness in __constant_memcpy in
arch/x86/include/asm/string_32.h (2.6.29-rc7).
1. The first switch is missing a case for n equal 7.
2. When n < 20, the four tests (n > 16, n > 12, n > 8 & n > 4)
execute identical statements; always 'asm volatile("movsl" :
"=&D"(edi), "=&S"(esi) : "0"(edi), "1"(esi) : "memory")'.
I think it copies less than 4 bytes for values of n between 9 and 19.
next reply other threads:[~2009-03-14 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 16:06 David Newall [this message]
2009-03-14 22:53 ` Screwy arch/x86/include/asm/string_32.h Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BBD619.6050809@davidnewall.com \
--to=davidn@davidnewall.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.