From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LiY2l-0003xs-6G for mharc-grub-devel@gnu.org; Sat, 14 Mar 2009 13:53:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiY2j-0003xg-Fi for grub-devel@gnu.org; Sat, 14 Mar 2009 13:53:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiY2e-0003wi-5H for grub-devel@gnu.org; Sat, 14 Mar 2009 13:53:04 -0400 Received: from [199.232.76.173] (port=50041 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiY2d-0003wc-R5 for grub-devel@gnu.org; Sat, 14 Mar 2009 13:52:59 -0400 Received: from mail-fx0-f176.google.com ([209.85.220.176]:50024) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LiY2d-00079R-Bz for grub-devel@gnu.org; Sat, 14 Mar 2009 13:52:59 -0400 Received: by fxm24 with SMTP id 24so3165853fxm.42 for ; Sat, 14 Mar 2009 10:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=kG/vcc3MucDV0LzErsqCGyyIHQn5iUjX+xaqvTifZus=; b=lZm15LvhQmAr7UzdNkQoMH++XQrxYuliNgDBpQC6ktlb7bh9VvPG1jctcfpYm1d1DK kQRF/USZr9iYxh/2uRG2XVJYt2OMXBIPKzB3SuavfRJQWEkoHEhlGxQvmpD1imRHM+U9 7XlHD88pNrinKSDCG50tJ51FIluTCCY6phbXU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=aNVs023sMNWrEr9BELwlNKy+v6OZq/8jiFYHjHQe1SxnuMR8gQRLOrYax2C7odJWTj CknR/8MD/yq65G+bmbqD41tNrK+Cru5daWT41tNKiJJI6J7CxqFqOjKub07Dj5MKko0W ZjH6i8GAb7vxmTxGNWesO8wK5SGFcJfBaQuFE= Received: by 10.103.138.16 with SMTP id q16mr1269567mun.114.1237053176886; Sat, 14 Mar 2009 10:52:56 -0700 (PDT) Received: from ?129.132.210.77? (vpn-global-dhcp3-077.ethz.ch [129.132.210.77]) by mx.google.com with ESMTPS id i7sm6386435mue.44.2009.03.14.10.52.56 (version=SSLv3 cipher=RC4-MD5); Sat, 14 Mar 2009 10:52:56 -0700 (PDT) Message-ID: <49BBEEF7.9000107@gmail.com> Date: Sat, 14 Mar 2009 18:52:55 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <4992ABA6.7040200@gmail.com> <49BAEDAD.3030704@gmail.com> <20090314144844.GA13451@thorin> In-Reply-To: <20090314144844.GA13451@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] Move multiboot helpers out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2009 17:53:06 -0000 Robert Millan wrote: > On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote: >> Index: conf/i386-ieee1275.rmk >> =================================================================== >> --- conf/i386-ieee1275.rmk (revision 2030) >> +++ conf/i386-ieee1275.rmk (working copy) >> @@ -126,10 +126,12 @@ >> >> # For _multiboot.mod. >> _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \ >> + loader/i386/multiboot_helper.S \ > > multiboot_helper.S is not being used on i386-ieee1275 AFAICT How can it be if multiboot.c is the same for pc and ieee1275? > >> - /* Unload all modules and stop the floppy driver. */ >> - call EXT_C(grub_dl_unload_all) > > grub_dl_unload_all() just disappeared. Is this intentional? I > tend to agree that grub_dl_unload_all() is a waste of time, but > this should be discussed separately. It is intentional because multiboot_real_boot is now in a module so we can't unload it > >> - call EXT_C(grub_stop_floppy) > > grub_stop_floppy() was moved to grub_multiboot_boot(). I think > grub_machine_fini() would be the more appropiate place. I'm not > sure why it was in those asm snippets to begin with (does someone > know?). > I'll have a look at it > Also, grub_unix_real_boot() completely disappeared with your patch. > This seems to break *BSD. > Last patch doesn't remove grub_unix_real_boot -- Regards Vladimir 'phcoder' Serbinenko