From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LidWj-0000PD-2S for mharc-grub-devel@gnu.org; Sat, 14 Mar 2009 19:44:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LidWh-0000MU-Gw for grub-devel@gnu.org; Sat, 14 Mar 2009 19:44:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LidWc-0000IT-TI for grub-devel@gnu.org; Sat, 14 Mar 2009 19:44:23 -0400 Received: from [199.232.76.173] (port=57313 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LidWc-0000IN-RA for grub-devel@gnu.org; Sat, 14 Mar 2009 19:44:18 -0400 Received: from fk-out-0910.google.com ([209.85.128.186]:48115) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LidWc-0003Kb-9W for grub-devel@gnu.org; Sat, 14 Mar 2009 19:44:18 -0400 Received: by fk-out-0910.google.com with SMTP id 19so1408855fkr.10 for ; Sat, 14 Mar 2009 16:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=dTNNN5ocav4HAGX2+xWG7Ye/pfDtJ0z0uHrBtRKwxC4=; b=Yk6C2OxhUfJkX5QkwhGF6b2yBzMe+zLheGgs9XuOUFFDWPqx0UmyXgSdxmxFlra51M 3RTvDK3NEuzX/MVbSDeUhEAslSenANWp3iL7mpAMGw7YGWnSGjcIVQ4lyB0Pel/qy+L7 /ANbwai/hO/GPc8x/WZKPVJ784cZ+0zX2mDIg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=x9FMx0KWlV8beWtTsjUVV+YwRCMGrNfWw1qLw64PJv1Lx660+5APkQGl/kbUy2A44G wcxQF8DDTz7lNV4eLGb6kVQg/srDzgOfp0CdtqQLmSF/KjpaW1ExaH+ZlCP2X0Dp7g3c hMUKiRlqfwlTYJL6W0y0ThQlwMEOGntYCqUuI= Received: by 10.103.5.14 with SMTP id h14mr1388944mui.108.1237074257334; Sat, 14 Mar 2009 16:44:17 -0700 (PDT) Received: from ?192.168.1.25? (156-231.62-81.cust.bluewin.ch [81.62.231.156]) by mx.google.com with ESMTPS id e8sm7050885muf.48.2009.03.14.16.44.16 (version=SSLv3 cipher=RC4-MD5); Sat, 14 Mar 2009 16:44:17 -0700 (PDT) Message-ID: <49BC414F.1040601@gmail.com> Date: Sun, 15 Mar 2009 00:44:15 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090314.151417.194555320.davem@davemloft.net> In-Reply-To: <20090314.151417.194555320.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: GRUB device names wrt. ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2009 23:44:23 -0000 For me it looks like it's disk driver-specific (ofdisk) and not platform-specific. Perhaps quoting or escaping could offer a better solution? David Miller wrote: > One issue I need to resolve before I can send finalized > patches out for sparc is about device naming. > > Currently the PowerPC ieee1275 support allows using both device > aliases and full openfirmware device path names with the usual GRUB > partition specification concatenated at the end. For the most part > this is fine. > > This works for a large group of cases, but in general it will not > work. > > The problem is two fold: > > 1) "," characters can appear anywhere in an openfirmware path > name. For example my workstations disk is: > > /pci@1e,600000/pci@0/pci@9/pci@0/scsi@1/disk@0 > > There are no quick workarounds for this. For example, even if we > can change the partition fetching code in GRUB to use "strrchr()" > instead of "strchr()" in kern/disk.c:grub_disk_open() it will > still think the above path has partition ",600000" or something > silly like that. > > 2) Disks can have multiple comma seperated components especially > on SCSI in OF path names. For example a disk on target 2, > lun 3, would have final path component "disk@2,3" > > And currently that ",3" would look like a parition specification > to GRUB. > > Therefore, I would suggest that we adopt the openfirmware partition > specification of ":" on GRUB for ieee1275 platforms. > > Then we just have a machine specific path seperator, defined in > some header file and the kernel/disk.c code > and elsewhere use the macro instead of "," > > Any objections? > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko