All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: akataria@vmware.com
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: VMI broken on tip/master...
Date: Sat, 14 Mar 2009 16:45:26 -0700	[thread overview]
Message-ID: <49BC4196.3070204@goop.org> (raw)
In-Reply-To: <1236966968.14680.15.camel@alok-dev1>

Alok Kataria wrote:
> Hi Peter, 
>
> I was seeing a early fault when running tip/master with VMI enabled on
> VMware platform. 
> This early fault was in the vmi_patch code where we are applying
> paravirt_alternatives. After some trials i noticed that this is
> reproducible only with CONFIG_TRACING. With that disabled my VM boots
> again. 
>
> I started a git bisect after that, and git pointed to this as the bad
> commit
>
> commit 6cc3c6e12bb039047974ad2e7e2d46d15a1b762f
>     trace_clock: fix preemption bug
>
> I then reverted that commit from tip/master and the system did boot. 
> But I fail to understand how this simple patch would be causing things
> to fail in VMI. Any ideas ?
>   

Nope.  My first guess is that this is a misbisection, but the fact that 
reverting helps tends to undermine that diagnosis.

What crash are you seeing?  What kind of fault?  At what instruction?  
Doing what?  It's a bit hard to tell what you're actually seeing.

Does reverting the text_poke() changes make a difference?

    J

  parent reply	other threads:[~2009-03-14 23:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13 17:56 VMI broken on tip/master Alok Kataria
2009-03-14 23:20 ` Peter Zijlstra
2009-03-14 23:45   ` Jeremy Fitzhardinge
2009-03-16 16:04   ` Steven Rostedt
2009-03-16 22:03     ` Jeremy Fitzhardinge
2009-03-14 23:45 ` Jeremy Fitzhardinge [this message]
2009-03-16 22:42   ` Alok Kataria
2009-03-16 22:54     ` Jeremy Fitzhardinge
2009-03-16 23:49       ` Alok Kataria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BC4196.3070204@goop.org \
    --to=jeremy@goop.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akataria@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.